MCO-1870: Skip MCN condition transition test in clusters with ImageModeStatusReporting FeatureGate is enabled
#30505
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment |
openshift-ci
bot
added
the
approved
|
Scheduling required tests: |
…rting feature gate is enabled
isabella-janssen
force-pushed
the
mco-1870
branch
from
5f7b958 to
cda83de
Compare
isabella-janssen
changed the title
ImageModeStatusReporting FeatureGate is enabled
|
@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive |
|
@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bd5d3a20-c5c8-11f0-998f-21e1b9a8c3be-0 |
|
This repository is using now pipeline controller to divide tests and have 2 stage pipeline. To know more how to trigger tests in second stage, in case they are not triggered for whatever reason, please see: https://docs.ci.openshift.org/docs/how-tos/creating-a-pipeline/ |
|
Thank you for sharing @jmguzik! |
|
/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive |
|
@isabella-janssen: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8185d880-c619-11f0-8b54-d8bde81dad9c-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2 periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3 periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3 |
|
@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e82d830-c620-11f0-8342-029b0f6e63e6-0 |
|
@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@isabella-janssen: This pull request references MCO-1870 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm seems sane to me, feel free to unhold when ready /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @isabella-janssen Verified by running payload rehearsals: ✅ The MCN test ran in a default cluster (where ImageModeStatusReporting is not enabled) - https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-30505-nightly-4.21-e2e-aws-ovn-serial-1of2/1991519387365937152 |
openshift-ci-robot
added
the
verified
|
@isabella-janssen: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold The payload rehearsals ran as expected, so this should be good to go. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pipeline required |
|
Scheduling required tests: |
|
/retest-required |
|
/hold Revision cda83de was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Job Failure Risk Analysis for sha: cda83de
|
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/retest-required |
|
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
With the implementation of MCO-1870 being introduced in openshift/machine-config-operator#5411, the MachineConfigNode conditions will be different when a cluster has the
ImageModeStatusReportingFeatureGate enabled. The condition transitions for this situation are tested in the ImageModeStatusReporting tests, so this test can simply be skipped without losing test coverage.To verify this change, confirm that the
Should properly transition through MCN conditions on rebootless node updatetest is skipped in tech preview test clusters (periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial) and not skipped in default clusters (periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial).