Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #30338

/assign ormergi

Use GetIPAddressFamily and utilnet IP string helpers to filter
preconfigured IPs to only include addresses supported by the cluster under test.

Signed-off-by: Patryk Diak <[email protected]>
@maiqueb
Copy link
Contributor

maiqueb commented Oct 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 3, 2025

/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
/lgtm

/hold
@ormergi please feel free to remove the hold once e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview passes - just a sanity check.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, maiqueb, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@maiqueb
Copy link
Contributor

maiqueb commented Nov 3, 2025

/hold cancel

The lane has passed.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025
@maiqueb
Copy link
Contributor

maiqueb commented Nov 3, 2025

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 3, 2025
@openshift-ci-robot
Copy link

@maiqueb: This PR has been marked as verified by ci.

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maiqueb
Copy link
Contributor

maiqueb commented Nov 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2025
@openshift-ci-robot
Copy link

@maiqueb: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maiqueb
Copy link
Contributor

maiqueb commented Nov 3, 2025

@ormergi I'm unsure we can have a NO-JIRA here, since this is essentially a backport.

Would you advise/recommend a course of action ? @kyrtapz

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 3, 2025

/jira cherry-pick OCPBUGS-64592

@openshift-ci-robot
Copy link

@kyrtapz: Jira Issue OCPBUGS-64592 has been cloned as Jira Issue OCPBUGS-64593. Will retitle bug to link to clone.
/retitle OCPBUGS-64593: [release-4.20] NO-JIRA: Filter preconfiguredIPs based on cluster IP family support

In response to this:

/jira cherry-pick OCPBUGS-64592

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] NO-JIRA: Filter preconfiguredIPs based on cluster IP family support OCPBUGS-64593: [release-4.20] NO-JIRA: Filter preconfiguredIPs based on cluster IP family support Nov 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 3, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-64593, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #30338

/assign ormergi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 3, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 3, 2025
@openshift-ci-robot
Copy link

@kyrtapz: This pull request references Jira Issue OCPBUGS-64593, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-64592 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-64592 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0913987 and 2 for PR HEAD d0c827c in total

@ormergi
Copy link
Contributor

ormergi commented Nov 3, 2025

/retest-required

@ormergi
Copy link
Contributor

ormergi commented Nov 4, 2025

The job e2e-metal-ipi-ovn-ipv6 just failed for the third time.
Every time it failed was for different reason, all of them seem unrelated to this PR changes.
I hope we can can have an excption this time and override the job.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 4, 2025

Only virt jobs are affected by this change.
/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@kyrtapz: kyrtapz unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

In response to this:

Only virt jobs are affected by this change.
/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Nov 4, 2025

/retest-required

@neisw
Copy link
Contributor

neisw commented Nov 4, 2025

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/skip

job has passed but timed out at the end a couple of times

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/skip

job has passed but timed out at the end a couple of times

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 407b0fa and 1 for PR HEAD d0c827c in total

@ormergi
Copy link
Contributor

ormergi commented Nov 4, 2025

/retest-required

@neisw
Copy link
Contributor

neisw commented Nov 4, 2025

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neisw
Copy link
Contributor

neisw commented Nov 4, 2025

/test verify

3 similar comments
@ormergi
Copy link
Contributor

ormergi commented Nov 4, 2025

/test verify

@ormergi
Copy link
Contributor

ormergi commented Nov 4, 2025

/test verify

@neisw
Copy link
Contributor

neisw commented Nov 4, 2025

/test verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 d0c827c link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit be01d22 into openshift:release-4.20 Nov 5, 2025
19 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-64593
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64593 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is an automated cherry-pick of #30338

/assign ormergi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.20.0-0.nightly-2025-11-05-192504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants