-
Notifications
You must be signed in to change notification settings - Fork 4.8k
test/extended/image_ecosystem.NewSampleRepoTest(): fix django-psql #30376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ba4bac8 to
fd01411
Compare
|
There are other references to this repository in examples and samples that I didn't touch. Should they be updated to refer to the same tag that this one uses, where it does? |
fd01411 to
77539a8
Compare
|
Rebased. The go-verify-deps is complaining about go.mod mentioning github.com/openshift/api v3.9.0+incompatible, even though go.mod also overrides it with a "replace" directive later on. |
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 77539a8
New tests seen in this PR at sha: 77539a8
|
|
Where is this test exercised? I only saw one multi arch job that failed this. I wonder if I can see the change taking effect in one of the presubmits |
|
This test is used in openshift/builder, in my case openshift/builder#469. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77539a8 to
e812c60
Compare
The template for django-psql-example apps doesn't specify a branch, but the default branch no longer contains anything. Update the test to supply "2.2.x" as the branch name to use in the https://github.com/sclorg/django-ex.git repository. Signed-off-by: Nalin Dahyabhai <[email protected]>
e812c60 to
7fd371e
Compare
|
@nalind: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 7fd371e
|
The template for django-psql-example apps doesn't specify a branch, but the default branch no longer contains anything.
Update the test to supply "2.2.x" as the branch name to use in the https://github.com/sclorg/django-ex.git repository.