OCPBUGS-63040: Add imagestream update dryrun test #30357

wangke19 · 2025-10-09T08:18:09Z

What does this do?

PR OCPBUGS-35855: Wire dry run option to Image API server operations openshift-apiserver#511 fixed imagestream with --dry-run=server bug. which includes creation/update/deletion operations.
But newly discovered that, creation of imagestream with --dry-run=server doesn't work as expected, filed one bug https://issues.redhat.com/browse/OCPBUGS-62875 for this.

$ oc create imagestream dryrun-test --dry-run=server -o yaml -n test1

$ oc get is dryrun-test -n test1
NAME          IMAGE REPOSITORY                                                     TAGS   UPDATED
dryrun-test   image-registry.xxxxxx.svc:5000/test1/dryrun-test

so only add update of imagestream with --dry-run=server test.

Fixed the error in disconection cluster we see from sippy, use an existing internal image stream tag openshift/cli:latest instead.

fail [github.com/openshift/origin/test/extended/images/dryrun.go:26]: Unexpected error:
    <*errors.errorString | 0xc00773a040>: 
    timed out while waiting of an image stream tag e2e-test-image-dry-run-d8lks/test:latest
    {
        s: "timed out while waiting of an image stream tag e2e-test-image-dry-run-d8lks/test:latest",
    }
occurred

For verify job,

Fix gofmt import ordering in test/extended/images/dryrun.go
Fix invalid JSON format in test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json

wangke19 · 2025-10-09T12:03:49Z

/cc @ardaguclu

wangke19 · 2025-10-09T12:07:46Z

/verified by e2e ci/prow/e2e-vsphere-ovn

openshift-ci-robot · 2025-10-09T12:08:01Z

@wangke19: This PR has been marked as verified by e2e [ci/prow/e2e-vsphere-ovn](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30357/pull-ci-openshift-origin-main-e2e-vsphere-ovn/1976201901850497024).

In response to this:

/verified by e2e ci/prow/e2e-vsphere-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-trt · 2025-10-09T13:13:11Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 738b811

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 6, Pass: 6, Fail: 0, Flake: 0]

ardaguclu

This bug https://issues.redhat.com/browse/OCPBUGS-62875 is about 4.15. But I'm not sure that we backported the fix in this branch (I couldn't see the fix in here https://github.com/openshift/openshift-apiserver/commits/release-4.15/)?. So in my opinion, it is expected to not working on 4.15.

Additionally, creation and update are almost equal. If one of them works, it is likely that other one should work too.

test/extended/images/dryrun.go

wangke19 · 2025-10-10T08:29:56Z

This bug https://issues.redhat.com/browse/OCPBUGS-62875 is about 4.15. But I'm not sure that we backported the fix in this branch (I couldn't see the fix in here https://github.com/openshift/openshift-apiserver/commits/release-4.15/)?. So in my opinion, it is expected to not working on 4.15.

Additionally, creation and update are almost equal. If one of them works, it is likely that other one should work too.

The bug https://issues.redhat.com/browse/OCPBUGS-62875 was found on 4.21, not 4.15, it was not fixed in openshift/openshift-apiserver#511, it should not be fixed on all versions。

wangke19 · 2025-10-11T02:13:56Z

/retest

openshift-trt · 2025-10-11T06:07:33Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 98dd33d

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 10, Pass: 10, Fail: 0, Flake: 0]

ardaguclu · 2025-10-13T06:58:54Z

test/extended/images/dryrun.go

+		}()
+
+		g.By("verifying the imagestream was actually created")
+		_, err = oc.Run("get").Args("imagestream", "dryrun-test", "-o", "jsonpath={.metadata.name}").Output()


I think this needs to be wrapped with PollUntilContextTimeout. Otherwise, it is possible that imagestream hasn't been created yet which causes flaky behavior.

Sure, Updated.

ardaguclu · 2025-10-13T08:55:50Z

Thanks
/lgtm

wangke19 · 2025-10-13T12:32:56Z

/retest

wangke19 · 2025-10-13T13:58:45Z

/test verify

openshift-trt · 2025-10-13T15:12:43Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 6aa3223

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 8, Pass: 8, Fail: 0, Flake: 0]

wangke19 · 2025-10-13T18:33:38Z

/test verify

wangke19 · 2025-10-14T09:03:52Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2025-10-14T09:03:56Z

@wangke19: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-10-14T10:37:14Z

/retest-required

Remaining retests: 0 against base HEAD 00af731 and 2 for PR HEAD 5dc8051 in total

openshift-ci-robot · 2025-10-14T12:10:29Z

@wangke19: This pull request references Jira Issue OCPBUGS-63040, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What does this do?

PR OCPBUGS-35855: Wire dry run option to Image API server operations openshift-apiserver#511 fixed imagestream with --dry-run=server bug. which includes creation/update/deletion operations.
But newly discovered that, creation of imagestream with --dry-run=server doesn't work as expected, filed one bug https://issues.redhat.com/browse/OCPBUGS-62875 for this.
$ oc create imagestream dryrun-test --dry-run=server -o yaml -n test1

$ oc get is dryrun-test -n test1
NAME          IMAGE REPOSITORY                                                     TAGS   UPDATED
dryrun-test   image-registry.xxxxxx.svc:5000/test1/dryrun-test  
so only add update of imagestream with --dry-run=server test.

Fixed the error in disconection cluster we see from sippy, use an existing internal image stream tag openshift/cli:latest instead.
fail [github.com/openshift/origin/test/extended/images/dryrun.go:26]: Unexpected error:
   <*errors.errorString | 0xc00773a040>: 
   timed out while waiting of an image stream tag e2e-test-image-dry-run-d8lks/test:latest
   {
       s: "timed out while waiting of an image stream tag e2e-test-image-dry-run-d8lks/test:latest",
   }
occurred
For verify job,

Fix gofmt import ordering in test/extended/images/dryrun.go

Fix invalid JSON format in test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wangke19 · 2025-10-14T18:16:59Z

/test e2e-metal-ipi-ovn-ipv6

wangke19 · 2025-10-15T03:53:17Z

/jira refresh

openshift-ci-robot · 2025-10-15T03:53:22Z

@wangke19: This pull request references Jira Issue OCPBUGS-63040, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wangke19 · 2025-10-15T03:53:55Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-10-15T03:53:58Z

@wangke19: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-trt · 2025-10-15T06:19:21Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 5dc8051

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 14, Pass: 14, Fail: 0, Flake: 0]

openshift-ci-robot · 2025-10-15T12:30:10Z

/retest-required

Remaining retests: 0 against base HEAD 3ee15fc and 1 for PR HEAD 5dc8051 in total

wangke19 · 2025-10-15T13:08:46Z

/test e2e-aws-ovn-serial-2of2

openshift-ci · 2025-10-15T16:36:22Z

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt · 2025-10-15T16:40:16Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 5dc8051

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips	High - "[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 5dc8051

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 21, Pass: 21, Fail: 0, Flake: 0]

openshift-trt · 2025-10-15T17:14:42Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 5dc8051

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 21, Pass: 21, Fail: 0, Flake: 0]

openshift-trt · 2025-10-15T17:19:42Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 5dc8051

"[sig-imageregistry] Image --dry-run should not update resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 21, Pass: 21, Fail: 0, Flake: 0]

openshift-ci-robot · 2025-10-15T17:24:42Z

@wangke19: Jira Issue Verification Checks: Jira Issue OCPBUGS-63040
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63040 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

What does this do?

PR OCPBUGS-35855: Wire dry run option to Image API server operations openshift-apiserver#511 fixed imagestream with --dry-run=server bug. which includes creation/update/deletion operations.
But newly discovered that, creation of imagestream with --dry-run=server doesn't work as expected, filed one bug https://issues.redhat.com/browse/OCPBUGS-62875 for this.
$ oc create imagestream dryrun-test --dry-run=server -o yaml -n test1

$ oc get is dryrun-test -n test1
NAME          IMAGE REPOSITORY                                                     TAGS   UPDATED
dryrun-test   image-registry.xxxxxx.svc:5000/test1/dryrun-test  
so only add update of imagestream with --dry-run=server test.

Fixed the error in disconection cluster we see from sippy, use an existing internal image stream tag openshift/cli:latest instead.
fail [github.com/openshift/origin/test/extended/images/dryrun.go:26]: Unexpected error:
   <*errors.errorString | 0xc00773a040>: 
   timed out while waiting of an image stream tag e2e-test-image-dry-run-d8lks/test:latest
   {
       s: "timed out while waiting of an image stream tag e2e-test-image-dry-run-d8lks/test:latest",
   }
occurred
For verify job,

Fix gofmt import ordering in test/extended/images/dryrun.go

Fix invalid JSON format in test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-10-15T17:25:36Z

@wangke19: new pull request created: #30387

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-10-15T17:26:24Z

@wangke19: #30357 failed to apply on top of branch "release-4.19":

Applying: add more images dryrun tests
Applying: fix: gofmt and JSON validation issues
Using index info to reconstruct a base tree...
A	test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json deleted in HEAD and modified in fix: gofmt and JSON validation issues. Version fix: gofmt and JSON validation issues of test/extended/util/compat_otp/testdata/opm/render/validate/catalog-error/operator-2/index.json left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 fix: gofmt and JSON validation issues

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-10-17T13:22:10Z

Fix included in accepted release 4.21.0-0.nightly-2025-10-17-012128

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025

wangke19 force-pushed the ocpbugs-35855-tests branch from fd65143 to 738b811 Compare October 9, 2025 08:22

openshift-ci bot requested review from flavianmissi and p0lyn0mial October 9, 2025 08:26

wangke19 changed the title ~~[WIP]Add images update dryrun test~~ Add images update dryrun test Oct 9, 2025

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2025

wangke19 changed the title ~~Add images update dryrun test~~ Add imagestream update dryrun test Oct 9, 2025

openshift-ci bot requested a review from ardaguclu October 9, 2025 12:03

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 9, 2025

ardaguclu reviewed Oct 10, 2025

View reviewed changes

test/extended/images/dryrun.go Outdated Show resolved Hide resolved

test/extended/images/dryrun.go Outdated Show resolved Hide resolved

test/extended/images/dryrun.go Outdated Show resolved Hide resolved

wangke19 force-pushed the ocpbugs-35855-tests branch from 738b811 to d5f9f96 Compare October 10, 2025 08:25

wangke19 force-pushed the ocpbugs-35855-tests branch 2 times, most recently from 6c359a4 to 98dd33d Compare October 10, 2025 11:45

ardaguclu reviewed Oct 13, 2025

View reviewed changes

wangke19 force-pushed the ocpbugs-35855-tests branch from 98dd33d to 6aa3223 Compare October 13, 2025 08:49

openshift-ci bot assigned ardaguclu Oct 13, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025

wangke19 changed the title ~~Add imagestream update dryrun test~~ NO-JIRA:Add imagestream update dryrun test Oct 13, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025

wangke19 changed the title ~~NO-JIRA:Add imagestream update dryrun test~~ OCPBUGS-63040: Add imagestream update dryrun test Oct 14, 2025

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 14, 2025

openshift-ci bot requested a review from gangwgr October 14, 2025 12:10

openshift-merge-bot bot merged commit 3250567 into openshift:main Oct 15, 2025
21 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 15, 2025

[release-4.20] OCPBUGS-63171: Add imagestream update dryrun test #30387

Closed

wangke19 deleted the ocpbugs-35855-tests branch October 15, 2025 17:37

This was referenced Oct 16, 2025

[release-4.20] OCPBUGS-63171: Add imagestream update dryrun test #30388

Closed

[release-4.20] OCPBUGS-63171: Add imagestream update dryrun test #30389

Merged

OCPBUGS-63040: Add imagestream update dryrun test #30357

OCPBUGS-63040: Add imagestream update dryrun test #30357

Uh oh!

Conversation

wangke19 commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wangke19 commented Oct 9, 2025

Uh oh!

wangke19 commented Oct 9, 2025

Uh oh!

openshift-ci-robot commented Oct 9, 2025

Uh oh!

openshift-trt bot commented Oct 9, 2025

Uh oh!

ardaguclu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangke19 commented Oct 10, 2025

Uh oh!

wangke19 commented Oct 11, 2025

Uh oh!

openshift-trt bot commented Oct 11, 2025

Uh oh!

ardaguclu Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

wangke19 Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Oct 13, 2025

Uh oh!

wangke19 commented Oct 13, 2025

Uh oh!

wangke19 commented Oct 13, 2025

Uh oh!

openshift-trt bot commented Oct 13, 2025

Uh oh!

wangke19 commented Oct 13, 2025

Uh oh!

wangke19 commented Oct 14, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

wangke19 commented Oct 14, 2025

Uh oh!

wangke19 commented Oct 15, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

wangke19 commented Oct 15, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 15, 2025

Uh oh!

openshift-trt bot commented Oct 15, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

wangke19 commented Oct 15, 2025

Uh oh!

openshift-ci bot commented Oct 15, 2025

Uh oh!

openshift-trt bot commented Oct 15, 2025

Uh oh!

openshift-trt bot commented Oct 15, 2025

Uh oh!

openshift-trt bot commented Oct 15, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 15, 2025

Uh oh!

wangke19 commented Oct 9, 2025 •

edited

Loading