Skip to content

[release-4.19] OCPBUGS-62843: fix(test): prevent nil pointer dereference in ginkgo test runner #30349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] OCPBUGS-62843: fix(test): prevent nil pointer dereference in ginkgo test runner #30349

wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 8, 2025

This is an automated cherry-pick of #30224

/assign openshift-ci-robot

@bryan-cox
fix(test): prevent nil pointer dereference in ginkgo test runner
ea43939 
Add nil checks to recordTestResultInMonitor, recordTestResultInLog, and
TestEnded functions to prevent segmentation faults when testRunResult
is nil during error conditions like network connectivity issues.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-61398 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.19] OCPBUGS-62843: fix(test): prevent nil pointer dereference in ginkgo test runner

In response to this:

This is an automated cherry-pick of #30224

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-61398: fix(test): prevent nil pointer dereference in ginkgo test runner [release-4.19] OCPBUGS-62843: fix(test): prevent nil pointer dereference in ginkgo test runner Oct 8, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62843, which is invalid:

  • expected dependent Jira Issue OCPBUGS-62841 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #30224

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial October 8, 2025 13:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 ea43939 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn ea43939 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@openshift-ci-robot openshift-ci-robot

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @openshift-ci-robot @bryan-cox