Skip to content

Add priority value tests for default priorityClassNames #30268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CoreyCook8 wants to merge 9 commits into from
Closed

Add priority value tests for default priorityClassNames #30268

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f4d7e38
Add priorityClassName tests for default values
CoreyCook8 Sep 17, 2025
753d94c
update bind data
CoreyCook8 Sep 17, 2025
1d0e265
Use the right filepath
CoreyCook8 Sep 18, 2025
1d668fb
no template
CoreyCook8 Sep 18, 2025
8e6c282
add namespace and delete pods
CoreyCook8 Sep 18, 2025
389b19a
correct priority
CoreyCook8 Sep 18, 2025
47ce8ab
cast
CoreyCook8 Sep 19, 2025
84ad3df
rename tests and update image
CoreyCook8 Sep 24, 2025
9f18d74
resolve conflicts
CoreyCook8 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions test/extended/pods/priorityclasses.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"strings"

. "github.com/onsi/ginkgo/v2"
o "github.com/onsi/gomega"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/sets"
e2e "k8s.io/kubernetes/test/e2e/framework"
Expand Down Expand Up @@ -88,6 +89,41 @@ var _ = Describe("[sig-arch] Managed cluster should", func() {
})
})

var _ = Describe("[sig-node] Pod priority should match the default priorityClassName values", func() {
defer GinkgoRecover()
var (
oc = exutil.NewCLI("priority-class-name")
systemNodeCriticalPodFile = exutil.FixturePath("testdata", "priority-class-name", "system-node-critical.yaml")
systemClusterCriticalPodFile = exutil.FixturePath("testdata", "priority-class-name", "system-cluster-critical.yaml")
)

It("system-node-critical=2000001000", func() {
By("creating the pods")
err := oc.Run("create").Args("-n", oc.Namespace(), "-f", systemNodeCriticalPodFile).Execute()
o.Expect(err).NotTo(o.HaveOccurred())

By("checking the pod priority")
pod, err := oc.KubeClient().CoreV1().Pods(oc.Namespace()).Get(context.Background(), "pod-with-system-node-critical-priority-class", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect((int)(*pod.Spec.Priority)).To(o.Equal(2000001000))
err = oc.KubeClient().CoreV1().Pods(oc.Namespace()).Delete(context.Background(), "pod-with-system-node-critical-priority-class", metav1.DeleteOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
})

It("system-cluster-critical=2000000000", func() {
By("creating the pods")
err := oc.Run("create").Args("-n", oc.Namespace(), "-f", systemClusterCriticalPodFile).Execute()
o.Expect(err).NotTo(o.HaveOccurred())

By("checking the pod priority")
pod, err := oc.KubeClient().CoreV1().Pods(oc.Namespace()).Get(context.Background(), "pod-with-system-cluster-critical-priority-class", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
o.Expect((int)(*pod.Spec.Priority)).To(o.Equal(2000000000))
err = oc.KubeClient().CoreV1().Pods(oc.Namespace()).Delete(context.Background(), "pod-with-system-cluster-critical-priority-class", metav1.DeleteOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
})
})

func hasPrefixSet(name string, set sets.String) bool {
for _, prefix := range set.List() {
if strings.HasPrefix(name, prefix) {
Expand Down
66 changes: 66 additions & 0 deletions test/extended/testdata/bindata.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions test/extended/testdata/priority-class-name/system-cluster-critical.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: v1
kind: Pod
metadata:
name: pod-with-system-cluster-critical-priority-class
spec:
containers:
- name: busybox
image: busybox

@ingvagabund ingvagabund Sep 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busybox image has not been used in the tests before. Would you please try image-registry.openshift-image-registry.svc:5000/openshift/tools:latest instead? To reduce the number of pulled images. E.g. https://github.com/openshift/origin/blob/main/test/extended/testdata/cmd/test/cmd/testdata/rollingupdate-daemonset.yaml#L30-L31 runs sleep command through tools:latest as well.

command:
- sleep
- "3600"
priorityClassName: system-cluster-critical
12 changes: 12 additions & 0 deletions test/extended/testdata/priority-class-name/system-node-critical.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: v1
kind: Pod
metadata:
name: pod-with-system-node-critical-priority-class
spec:
containers:
- name: busybox
image: busybox
command:
- sleep
- "3600"
priorityClassName: system-node-critical
4 changes: 4 additions & 0 deletions test/extended/util/annotate/generated/zz_generated.annotations.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.