-
Notifications
You must be signed in to change notification settings - Fork 4.8k
[release-4.19] OCPBUGS-56967: Do not set the MTU when using NetworkAttachementDefinition #29879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.19] OCPBUGS-56967: Do not set the MTU when using NetworkAttachementDefinition #29879
Conversation
The static MTU can be incorrect in some clusters, instead rely on the fact that when the MTU is left unset OVN-Kubernetes will use a default equal to the clusterNetworkMTU. https://github.com/ovn-kubernetes/ovn-kubernetes/blob/1df91ecad2dc2e283dd4106e2e5069aff9eb1eb5/go-controller/pkg/config/cni.go#L103 Signed-off-by: Patryk Diak <pdiak@redhat.com>
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-55994 has been cloned as Jira Issue OCPBUGS-56967. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56967, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
trozet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@kyrtapz: An error was encountered updating to the POST state for bug OCPBUGS-56967 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Post "https://issues.redhat.com/rest/api/2/issue/17025233/transitions": POST https://issues.redhat.com/rest/api/2/issue/17025233/transitions giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@kyrtapz: This pull request references Jira Issue OCPBUGS-56967, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
@trozet: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
58eaf4b
into
openshift:release-4.19
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-56967: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-56967 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
@kyrtapz: new pull request created: #29891 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
|
Fix included in accepted release 4.19.0-0.nightly-2025-06-06-115013 |
This is an automated cherry-pick of #29768
/assign kyrtapz