Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #29727

/assign pliurh

pliurh added 4 commits May 9, 2025 20:29
1. Tests for both IPv4 and IPv6 EgressIP
2. Tests for advertising EgressIP for the default network and UDN
   to the default VRF.
Parse tcpdump output based on regex instead of position.

Send probe requests with a sequence number for debgging.

Use ClusterIP instead of route as the prober target.

Signed-off-by: Peng Liu <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2025

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORENET-5875, CORENET-5876
Jira Issue OCPBUGS-55910 has been cloned as Jira Issue OCPBUGS-56000. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-56000, CORENET-5875, CORENET-5876: Add EgressIP and L2 UDN route advertisements tests

Details

In response to this:

This is an automated cherry-pick of #29727

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-55910, CORENET-5875, CORENET-5876: Add EgressIP and L2 UDN route advertisements tests [release-4.19] OCPBUGS-56000, CORENET-5875, CORENET-5876: Add EgressIP and L2 UDN route advertisements tests May 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56000, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55910 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-55910 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CORENET-5875 which is a valid jira issue.

This pull request references CORENET-5876 which is a valid jira issue.

Details

In response to this:

This is an automated cherry-pick of #29727

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented May 12, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@neisw
Copy link
Contributor

neisw commented May 12, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, neisw, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 12, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fca6932 and 2 for PR HEAD 78cd6c7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 12, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 78cd6c7 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 78cd6c7 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 78cd6c7 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 78cd6c7 link false /test e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-ovn 78cd6c7 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fca6932 and 2 for PR HEAD 78cd6c7 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 65422c8 into openshift:release-4.19 May 13, 2025
28 of 33 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56000: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56000 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #29727

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202505140813.p0.g65422c8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-05-15-043906

@jluhrsen
Copy link
Contributor

jluhrsen commented Jul 1, 2025

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Author

@jluhrsen: #29777 failed to apply on top of branch "release-4.18":

Applying: Add EgressIP route advertisement test
Using index info to reconstruct a base tree...
M	test/extended/networking/egressip_helpers.go
A	test/extended/networking/route_advertisements.go
M	test/extended/util/annotate/generated/zz_generated.annotations.go
M	zz_generated.manifests/test-reporting.yaml
Falling back to patching base and 3-way merge...
Auto-merging zz_generated.manifests/test-reporting.yaml
CONFLICT (content): Merge conflict in zz_generated.manifests/test-reporting.yaml
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (content): Merge conflict in test/extended/util/annotate/generated/zz_generated.annotations.go
CONFLICT (modify/delete): test/extended/networking/route_advertisements.go deleted in HEAD and modified in Add EgressIP route advertisement test. Version Add EgressIP route advertisement test of test/extended/networking/route_advertisements.go left in tree.
Auto-merging test/extended/networking/egressip_helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add EgressIP route advertisement test

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.