-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPBUGS-55712: (olmv1 tests) Use exponential backoffs for verifyAPIEndpoints #29756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-55712: (olmv1 tests) Use exponential backoffs for verifyAPIEndpoints #29756
Conversation
4d8f791 to
60caeb5
Compare
test/extended/olm/olmv1.go
Outdated
| Factor: 1.5, | ||
| Jitter: 0.1, | ||
| Steps: 10, | ||
| Cap: 30 * time.Second, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be multiple minutes... at a minimum 2.
Polling with 30 secs timeout is causing thundering herd problem, causing the tests to timeout in resource constrained CI environments. This PR switches to using exponential backoffs with jitter.
60caeb5 to
f8b59e8
Compare
tmshort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
retitle OCPBUGS-55712: (olmv1 tests) Use exponential backoffs for verifyAPIEndpoints |
|
/retitle OCPBUGS-55712: (olmv1 tests) Use exponential backoffs for verifyAPIEndpoints |
|
/title OCPBUGS-55712: (olmv1 tests) Use exponential backoffs for verifyAPIEndpoints |
verifyAPIEndpoints|
@anik120: This pull request references Jira Issue OCPBUGS-55712, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@grokspawn: This pull request references Jira Issue OCPBUGS-55712, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
/retest-required |
|
/retest-required |
2 similar comments
|
/skip |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-metal-ipi-ovn-ipv6 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-metal-ipi-ovn-ipv6 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-edge-zones known outage and has passed multiple times previously |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-edge-zones DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/skip |
|
/override ci/prow/e2e-aws-ovn-edge-zones |
|
@tmshort: tmshort unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-edge-zones |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-edge-zones DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-edge-zones |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-edge-zones DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/override ci/prow/e2e-aws-ovn-edge-zones |
|
@tmshort: tmshort unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn-edge-zones |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-edge-zones DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
@anik120: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
@anik120: Jira Issue OCPBUGS-55712: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55712 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
|
The fixed PR for 4.19: #29770 |
Polling with 30 secs timeout is causing thundering herd problem, causing the tests to timeout in resource constrained CI environments. This PR switches to using exponential backoffs with jitter.