creating gateway object for GatewayAPIController #29642
Conversation
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test all |
|
/test e2e-gcp-ovn-techpreview |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: melvinjoseph86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| // check whether status of dns reccord is True | ||
| dnsRecordstatus, err := oc.AsAdmin().Run("get").Args("-n", "openshift-ingress", "dnsrecord", `-o=jsonpath={.items[0].status.zones[0].conditions[0].status}`).Output() | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| o.Expect(dnsRecordstatus).To(o.Equal("True")) |
There was a problem hiding this comment.
@melvinjoseph86 suggest to use the specific variable dnsRecordName when chacking for the status because depending on the gateway, sometimes multiple DNSRecords may be created, or another gateway could have other DNSRecords present
|
@melvinjoseph86: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close |
|
@melvinjoseph86: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Runner logs:-