Skip to content

Conversation

@ardaguclu
Copy link
Member

By this openshift/api#2017 (and the corresponding changes in upstream), all resources have metadata field. When we bump the dependencies in oc, these changes are also coming in (openshift/oc#1877). On the other hand, openshift-apiserver is not ready yet to understand the metadata field in resources and so it raises a warning about Warning: unknown field \"metadata\". Although this is just a warning, this causes failures in the test [sig-cli] policy scc-subject-review, scc-review (e.g. failed test run).

Ideally we should wait the merge of openshift/openshift-apiserver#444 (which waits for openshift/openshift-apiserver#441) and expect that problem disappears automatically.

But these changes may not be merged in soon and this PR alternatively loosens the test check to unblock the oc bump 1.31. Once the changes in openshift-apiserver is merged, we can revert back to equality check.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2024

@ardaguclu: This pull request references WRKLDS-1492 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

By this openshift/api#2017 (and the corresponding changes in upstream), all resources have metadata field. When we bump the dependencies in oc, these changes are also coming in (openshift/oc#1877). On the other hand, openshift-apiserver is not ready yet to understand the metadata field in resources and so it raises a warning about Warning: unknown field \"metadata\". Although this is just a warning, this causes failures in the test [sig-cli] policy scc-subject-review, scc-review (e.g. failed test run).

Ideally we should wait the merge of openshift/openshift-apiserver#444 (which waits for openshift/openshift-apiserver#441) and expect that problem disappears automatically.

But these changes may not be merged in soon and this PR alternatively loosens the test check to unblock the oc bump 1.31. Once the changes in openshift-apiserver is merged, we can revert back to equality check.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@ardaguclu
Copy link
Member Author

https://issues.redhat.com/browse/OCPBUGS-42532 is opened to track the revert work.

@ardaguclu
Copy link
Member Author

/test ci/prow/e2e-metal-ipi-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

@ardaguclu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-certrotation
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-ipsec-serial
  • /test e2e-aws-ovn-kube-apiserver-rollout
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-microshift
  • /test e2e-aws-ovn-microshift-serial
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-techpreview
  • /test e2e-aws-ovn-single-node-techpreview-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upgrade-rollback
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-azure-ovn-upgrade
  • /test e2e-baremetalds-kubevirt
  • /test e2e-external-aws
  • /test e2e-external-aws-ccm
  • /test e2e-external-vsphere-ccm
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-local-gateway
  • /test e2e-metal-ipi-ovn-kube-apiserver-rollout
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout
  • pull-ci-openshift-origin-master-e2e-aws-ovn-microshift
  • pull-ci-openshift-origin-master-e2e-aws-ovn-microshift-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test ci/prow/e2e-metal-ipi-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ardaguclu
Copy link
Member Author

/test e2e-metal-ipi-ovn

@stbenjam
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, atiratree, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: ce44cb3

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial High
[sig-network-edge][Feature:Idling] Unidling with Deployments [apigroup:route.openshift.io] should handle many UDP senders (by continuing to drop all packets on the floor) [Serial] [Suite:openshift/conformance/serial]
This test has passed 100.00% of 52 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.

@ardaguclu
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit b81ba7d into openshift:master Sep 30, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade ce44cb3 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202409302338.p0.gb81ba7d.assembly.stream.el9.
All builds following this will include this PR.

@ardaguclu ardaguclu deleted the loosen-scc-test-check branch October 1, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants