-
Notifications
You must be signed in to change notification settings - Fork 4.8k
WRKLDS-1492: Loosen output check in policy scc-subject-review, scc-review test #29141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRKLDS-1492: Loosen output check in policy scc-subject-review, scc-review test #29141
Conversation
|
@ardaguclu: This pull request references WRKLDS-1492 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
https://issues.redhat.com/browse/OCPBUGS-42532 is opened to track the revert work. |
|
/test ci/prow/e2e-metal-ipi-ovn |
|
@ardaguclu: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-metal-ipi-ovn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, atiratree, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Job Failure Risk Analysis for sha: ce44cb3
|
|
/retest |
|
@ardaguclu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
By this openshift/api#2017 (and the corresponding changes in upstream), all resources have metadata field. When we bump the dependencies in oc, these changes are also coming in (openshift/oc#1877). On the other hand, openshift-apiserver is not ready yet to understand the metadata field in resources and so it raises a warning about
Warning: unknown field \"metadata\". Although this is just a warning, this causes failures in the test[sig-cli] policy scc-subject-review, scc-review(e.g. failed test run).Ideally we should wait the merge of openshift/openshift-apiserver#444 (which waits for openshift/openshift-apiserver#441) and expect that problem disappears automatically.
But these changes may not be merged in soon and this PR alternatively loosens the test check to unblock the oc bump 1.31. Once the changes in openshift-apiserver is merged, we can revert back to equality check.