Skip to content

Report external binary usage #28000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Jun 29, 2023
Merged

Report external binary usage #28000

openshift-merge-robot merged 3 commits into from
Jun 29, 2023

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 26, 2023 •
edited
Loading

Report external binary usage like other synthetic tests.

/assign @bparees @ingvagabund

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@soltysh soltysh mentioned this pull request Jun 26, 2023
Merged
@openshift-ci openshift-ci bot requested review from csrwng and spadgett June 26, 2023 13:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
bparees
bparees reviewed Jun 26, 2023
View reviewed changes
soltysh added 3 commits June 29, 2023 10:53
@soltysh
Remove automatic fallback to built-in tests
bab1e62 
Users willing to run vendored k8s tests need to explicitly set
OPENSHIFT_SKIP_EXTERNAL_TESTS environment variable.
@soltysh
Report the actual tag when searching through release image
04fcffe
@soltysh
Add a synthetic flake for the external binary usage
54dff46
@soltysh soltysh force-pushed the remove_automatic_fallback branch from 76a2342 to 54dff46 Compare June 29, 2023 10:22
@soltysh soltysh changed the title Remove automatic fallback to built-in tests Report external binary usage Jun 29, 2023
@soltysh
Copy link
Contributor Author

soltysh commented Jun 29, 2023

/hold cancel
/assign @deads2k

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 29, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7176b15 into openshift:master Jun 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 54dff46 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-openstack-ovn 54dff46 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 54dff46 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh soltysh deleted the remove_automatic_fallback branch June 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees bparees left review comments

@csrwng csrwng Awaiting requested review from csrwng

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@bparees bparees

@ingvagabund ingvagabund

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@soltysh @deads2k @bparees @ingvagabund @openshift-merge-robot