Skip to content

OCPBUGS-14342: Increase timeout in sysctl allowlist test #27956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 31, 2023
Merged

OCPBUGS-14342: Increase timeout in sysctl allowlist test #27956

openshift-merge-robot merged 1 commit into from
May 31, 2023

Conversation

@mlguerrero12
Copy link
Member

@mlguerrero12 mlguerrero12 commented May 31, 2023

This test sometimes fails because the allowlist controller takes more than 30s to update the sysctl allowlist file. This controller waits up to 60s for the pods of the DS to be in ready state.

This is a cherry-pick of #27955

OCPBUGS-14321: Increase timeout in sysctl allowlist test
67e9613 
This test sometimes fails because the allowlist controller takes
more than 30s to update the sysctl allowlist file. This controller
waits up to 60s for the pods of the DS to be in ready state.

Signed-off-by: Marcelo Guerrero <marguerr@redhat.com>
@openshift-ci openshift-ci bot requested review from knobunc and trozet May 31, 2023 12:16
@mlguerrero12
Copy link
Member Author

mlguerrero12 commented May 31, 2023

/jira cherrypick OCPBUGS-14321

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023

@mlguerrero12: Jira Issue OCPBUGS-14321 has been cloned as Jira Issue OCPBUGS-14342. Will retitle bug to link to clone.
/retitle OCPBUGS-14342: Increase timeout in sysctl allowlist test

Details

In response to this:

/jira cherrypick OCPBUGS-14321

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title Increase timeout in sysctl allowlist test OCPBUGS-14342: Increase timeout in sysctl allowlist test May 31, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023

@mlguerrero12: This pull request references Jira Issue OCPBUGS-14342, which is invalid:

  • expected dependent Jira Issue OCPBUGS-14321 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This test sometimes fails because the allowlist controller takes more than 30s to update the sysctl allowlist file. This controller waits up to 60s for the pods of the DS to be in ready state.

This is a cherry-pick of #27955

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mlguerrero12
Copy link
Member Author

mlguerrero12 commented May 31, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023

@mlguerrero12: This pull request references Jira Issue OCPBUGS-14342, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-14321 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-14321 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@mlguerrero12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 67e9613 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 67e9613 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Contributor

soltysh commented May 31, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 31, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlguerrero12, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@mlguerrero12
Copy link
Member Author

mlguerrero12 commented May 31, 2023

@bparees, could you please help me with the cherry-pick-approved label here? There is nothing for qe to do with this fix.

@gangwgr
Copy link
Contributor

gangwgr commented May 31, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit f210c2d into openshift:release-4.13 May 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023

@mlguerrero12: Jira Issue OCPBUGS-14342: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14342 has been moved to the MODIFIED state.

Details

In response to this:

This test sometimes fails because the allowlist controller takes more than 30s to update the sysctl allowlist file. This controller waits up to 60s for the pods of the DS to be in ready state.

This is a cherry-pick of #27955

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah mentioned this pull request May 31, 2023
Merged
@shellyyang1989 shellyyang1989 mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@trozet trozet Awaiting requested review from trozet

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dgoodwin dgoodwin

@stbenjam stbenjam

@kasturinarra kasturinarra

@jadhaj jadhaj

@sunilcio sunilcio

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.