OCPBUGS-6902: Fix dns-test #27699

derekhiggins · 2023-02-01T11:28:35Z

Testing the pods immediatly after creating the daemonset leads
to failures as they may not be ready.

openshift-ci-robot · 2023-02-01T11:28:39Z

@derekhiggins: This pull request references Jira Issue OCPBUGS-6902, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins · 2023-02-01T11:57:00Z

/payload-job periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6
/payload-job periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade

openshift-ci · 2023-02-01T11:57:04Z

@derekhiggins: trigger 2 job(s) for the /payload-(job|aggregate) command

periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/892019c0-a227-11ed-95b7-69acd2d6e798-0

derekhiggins · 2023-02-01T14:20:50Z

/payload-job periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade

openshift-ci · 2023-02-01T14:20:55Z

@derekhiggins: trigger 1 job(s) for the /payload-(job|aggregate) command

periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a10a4b50-a23b-11ed-9296-56d6c0b9109d-0

Testing the pods immediatly after creating the daemonset leads to failures as they may not be ready.

openshift-ci-robot · 2023-02-01T17:46:34Z

@derekhiggins: This pull request references Jira Issue OCPBUGS-6902, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Testing the pods immediatly after creating the daemonset leads
to failures as they may not be ready.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins · 2023-02-01T17:46:51Z

/unhold
/payload-job periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6
/payload-job periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade

openshift-ci · 2023-02-01T17:47:00Z

@derekhiggins: trigger 2 job(s) for the /payload-(job|aggregate) command

periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.13-e2e-metal-ipi-sdn-bm-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/68f594a0-a258-11ed-95b1-a9c3adf40050-0

openshift-ci-robot · 2023-02-01T17:57:03Z

@derekhiggins: This pull request references Jira Issue OCPBUGS-6902, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Testing the pods immediatly after creating the daemonset leads
to failures as they may not be ready.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins · 2023-02-02T08:55:43Z

/jira refresh
@deads2k mind taking a look

openshift-ci-robot · 2023-02-02T08:55:49Z

@derekhiggins: This pull request references Jira Issue OCPBUGS-6902, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @droslean

Details

In response to this:

/jira refresh
@deads2k mind taking a look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins · 2023-02-02T08:56:13Z

/cc @droslean

droslean · 2023-02-02T10:22:44Z

/lgtm
/approve
/hold

Holding the PR to let @deads2k review it as well.

derekhiggins · 2023-02-02T10:50:23Z

Here is the ipv6 upgrade payload job passing with this PR (its failure rate is somewhere around 90% at the moment)
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/openshift-origin-27699-nightly-4.13-e2e-metal-ipi-upgrade-ovn-ipv6/1620841151944724480

derekhiggins · 2023-02-03T11:10:14Z

/test required

openshift-ci · 2023-02-03T11:10:18Z

@derekhiggins: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-jenkins
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-serial
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test extended_gssapi
/test extended_ldap_groups
/test extended_networking
/test images
/test lint
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-csi-migration
/test e2e-aws-disruptive
/test e2e-aws-multitenant
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-sdn
/test e2e-metal-ipi-serial
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-openstack-kuryr
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere
/test e2e-vsphere-ovn-etcd-scaling
/test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-origin-master-e2e-aws-csi
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-origin-master-e2e-aws-ovn-etcd-scaling
pull-ci-openshift-origin-master-e2e-aws-ovn-fips
pull-ci-openshift-origin-master-e2e-aws-ovn-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
pull-ci-openshift-origin-master-e2e-azure-ovn-etcd-scaling
pull-ci-openshift-origin-master-e2e-gcp-csi
pull-ci-openshift-origin-master-e2e-gcp-ovn
pull-ci-openshift-origin-master-e2e-gcp-ovn-etcd-scaling
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
pull-ci-openshift-origin-master-e2e-openstack-ovn
pull-ci-openshift-origin-master-e2e-vsphere-ovn-etcd-scaling
pull-ci-openshift-origin-master-images
pull-ci-openshift-origin-master-lint
pull-ci-openshift-origin-master-unit
pull-ci-openshift-origin-master-verify
pull-ci-openshift-origin-master-verify-deps

Details

In response to this:

/test required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins · 2023-02-03T11:11:10Z

/retest-required

derekhiggins · 2023-02-07T09:54:34Z

/retest-required

openshift-ci · 2023-02-07T12:32:20Z

@derekhiggins: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

derekhiggins · 2023-02-08T09:53:47Z

Holding the PR to let @deads2k review it as well.

Hi @deads2k would you have a few minutes to take a look

soltysh

/hold
since the alternative is much better

soltysh · 2023-02-09T15:28:01Z

test/e2e/upgrade/dns/dns.go

 // to cover during and after upgrade phase, and verifies the results.
 func (t *UpgradeTest) Test(f *framework.Framework, done <-chan struct{}, _ upgrades.UpgradeType) {
+	ginkgo.By("Sleeping for a minute to give dns test pods some time to start")
+	time.Sleep(1 * time.Minute)


Sleeps are always a bad option, a better alternative is here: #27715

openshift-ci · 2023-02-09T15:29:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: derekhiggins, droslean
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-02-09T15:33:33Z

@derekhiggins: This pull request references Jira Issue OCPBUGS-6902. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Testing the pods immediatly after creating the daemonset leads
to failures as they may not be ready.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 1, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 1, 2023

openshift-ci bot requested review from bparees and soltysh February 1, 2023 11:30

OCPBUGS-6902: Give dns-test pods some time to start

295bce1

Testing the pods immediatly after creating the daemonset leads to failures as they may not be ready.

derekhiggins force-pushed the dns-test-fix branch from a6145e5 to 295bce1 Compare February 1, 2023 17:46

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023

openshift-ci bot requested a review from droslean February 2, 2023 08:55

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023

openshift-ci bot assigned droslean Feb 2, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023

soltysh suggested changes Feb 9, 2023

View reviewed changes

derekhiggins closed this Feb 9, 2023

OCPBUGS-6902: Fix dns-test #27699

OCPBUGS-6902: Fix dns-test #27699

Uh oh!

Conversation

derekhiggins commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

derekhiggins commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

derekhiggins commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

derekhiggins commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

derekhiggins commented Feb 2, 2023

Uh oh!

openshift-ci-robot commented Feb 2, 2023

Uh oh!

derekhiggins commented Feb 2, 2023

Uh oh!

droslean commented Feb 2, 2023

Uh oh!

derekhiggins commented Feb 2, 2023

Uh oh!

derekhiggins commented Feb 3, 2023

Uh oh!

openshift-ci bot commented Feb 3, 2023

Uh oh!

derekhiggins commented Feb 3, 2023

Uh oh!

derekhiggins commented Feb 7, 2023

Uh oh!

openshift-ci bot commented Feb 7, 2023

Uh oh!

derekhiggins commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

soltysh Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 9, 2023

Uh oh!

openshift-ci-robot commented Feb 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

derekhiggins commented Feb 1, 2023 •

edited

Loading

derekhiggins commented Feb 8, 2023 •

edited

Loading