OCPBUGS-9831: Make unidle test more strict by zeeke · Pull Request #27673 · openshift/origin

zeeke · 2023-01-19T16:00:50Z

Trying to reproduce https://bugzilla.redhat.com/show_bug.cgi?id=2091780

Unidled services should be reachable during the first connection attempt, it's important to not retry HTTP requests in tests.

See:

openshift-ci · 2023-01-19T16:00:56Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

zeeke · 2023-01-19T17:16:59Z

/test e2e-gcp-ovn

zeeke · 2023-01-19T17:32:29Z

/test e2e-gcp-ovn

openshift-ci · 2023-02-02T15:19:33Z

@zeeke: This pull request references Bugzilla bug 2091780, which is invalid:

expected the bug to target the "4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2091780: Make unidle test more strict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-23T17:33:08Z

@zeeke: This pull request references Bugzilla bug 2091780, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.13.0) matches configured target release for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2091780: Make unidle test more strict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-02T11:54:30Z

@zeeke: This pull request references Bugzilla bug 2091780, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.13.0) matches configured target release for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2091780: Make unidle test more strict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-02T11:55:23Z

@zeeke: This pull request references Bugzilla bug 2091780, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.13.0) matches configured target release for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

Bug 2091780: Make unidle test more strict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zeeke · 2023-03-02T15:51:00Z

/retest

Unidling a service should not raise TCP rejects. Ref: https://issues.redhat.com/browse/OCPBUGSM-44873 ovn-kubernetes/ovn-kubernetes#3408 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

zeeke · 2023-03-03T18:25:23Z

/retest

zeeke · 2023-03-23T08:59:34Z

/retest

as per

OCPBUGS-8080,OCPBUGS-8280,OCPBUGS-8278,OCPBUGS-7988,OCPBUGS-7932,OCPBUGS-9990: Downstream Merge [10-mar-2023] ovn-kubernetes#1574 (comment)

is merged

zeeke · 2023-03-23T13:03:41Z

/retest

zeeke · 2023-03-23T15:20:56Z

/retest

openshift-ci · 2023-03-23T18:21:44Z

@zeeke: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-9831: Make unidle test more strict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zeeke · 2023-03-23T18:28:43Z

This PR revemove the connection retry introduced by:

OCPBUGS-9831

As the TCP rejects of idled services has been fixed by:

@dcbw , @bparees Please take a look

cc @msherif1234 , @tssurya

trozet · 2023-03-24T14:29:45Z

/lgtm

zeeke · 2023-03-27T11:15:01Z

@bparees @dgoodwin
Need approval here. Can you take a look?

bparees · 2023-03-27T13:36:26Z

/approve

bparees · 2023-03-27T13:39:52Z

@zeeke approved, but the SDN team should consider moving this test under the networking dir where the team already has approval rights:
https://github.com/openshift/origin/blob/master/test/extended/networking/OWNERS

or adding a new OWNERS file in the idling dir so the team can merge PRs to this test themselves

openshift-ci · 2023-03-27T13:54:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, trozet, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-03-27T15:20:18Z

/retest-required

Remaining retests: 0 against base HEAD 480c4d0 and 2 for PR HEAD 538a74b in total

zeeke · 2023-03-27T15:31:19Z

Thanks @bparees, Idling feature involves three components working together (cli for oc idle, openshift-controller-manager for the replicas management, and the network CNI for the unidling trigger); I don't know if networking dir is a good place for it.

bparees · 2023-03-27T15:50:24Z

I don't know if networking dir is a good place for it.

in that case an OWNERs file in the existing dir might be the right solution (w/ approvers from all the teams you mentioned that have a stake in the test functionality)

zeeke · 2023-03-27T16:09:51Z

in that case an OWNERs file in the existing dir might be the right solution (w/ approvers from all the teams you mentioned that have a stake in the test functionality)

Sounds good to me!

zeeke · 2023-03-28T07:40:12Z

/retest-required

openshift-ci-robot · 2023-03-28T10:20:05Z

/retest-required

Remaining retests: 0 against base HEAD 9f98fce and 1 for PR HEAD 538a74b in total

zeeke · 2023-03-28T14:51:17Z

/retest-required

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27673/pull-ci-openshift-origin-master-e2e-aws-ovn-serial/1640660051779653632

[Serial] [sig-auth][Feature:OAuthServer] [RequestHeaders] [IdP] test RequestHeaders IdP [apigroup:config.openshift.io][apigroup:user.openshift.io][apigroup:apps.openshift.io] [Suite:openshift/conformance/serial]

seems not to be related to these changes.

openshift-ci-robot · 2023-03-28T18:12:40Z

/retest-required

Remaining retests: 0 against base HEAD 733399a and 0 for PR HEAD 538a74b in total

openshift-ci-robot · 2023-03-28T21:12:51Z

/hold

Revision 538a74b was retested 3 times: holding

zeeke · 2023-03-29T07:36:28Z

/retest-required

zeeke · 2023-03-29T10:28:08Z

/retest-required

openshift-ci · 2023-03-29T13:53:01Z

@zeeke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-serial	`538a74b`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-openstack-ovn	`538a74b`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-vsphere-ovn-etcd-scaling	`538a74b`	link	false	`/test e2e-vsphere-ovn-etcd-scaling`
ci/prow/e2e-azure-ovn-etcd-scaling	`538a74b`	link	false	`/test e2e-azure-ovn-etcd-scaling`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zeeke · 2023-03-29T14:31:15Z

/retest-required
/hold cancel

Job ci/prow/e2e-aws-ovn-serial is flaky as discussed in this thread

openshift-ci-robot · 2023-03-29T19:46:35Z

@zeeke: Jira Issue OCPBUGS-9831: All pull requests linked via external trackers have merged:

openshift/origin#27673

Jira Issue OCPBUGS-9831 has been moved to the MODIFIED state.

Details

In response to this:

Trying to reproduce https://bugzilla.redhat.com/show_bug.cgi?id=2091780

Unidled services should be reachable during the first connection attempt, it's important to not retry HTTP requests in tests.

See:

https://issues.redhat.com/browse/OCPBUGSM-44873

Service: Avoid rejecting when service is unidled ovn-kubernetes/ovn-kubernetes#3408

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2023-03-30T18:32:00Z

Sorry folks, the tighter test started blocking payloads.

Revert: #27833

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2023

zeeke force-pushed the ocpbugsm-44873 branch from 622d98e to 6307590 Compare January 19, 2023 17:31

zeeke changed the title ~~Make unidle test more strict~~ Bug 2091780: Make unidle test more strict Feb 2, 2023

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 2, 2023

zeeke force-pushed the ocpbugsm-44873 branch from 6307590 to 04272d5 Compare February 23, 2023 17:30

zeeke marked this pull request as ready for review February 23, 2023 17:31

openshift-ci bot requested review from Miciah, anuragthehatter and frobware February 23, 2023 17:33

zeeke force-pushed the ocpbugsm-44873 branch 2 times, most recently from 45bc6e3 to 9ce5c18 Compare March 2, 2023 11:53

zeeke force-pushed the ocpbugsm-44873 branch from 9ce5c18 to 34d1cc1 Compare March 2, 2023 15:58

idling: Stricter check on idled services

538a74b

Unidling a service should not raise TCP rejects. Ref: https://issues.redhat.com/browse/OCPBUGSM-44873 ovn-kubernetes/ovn-kubernetes#3408 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>

zeeke force-pushed the ocpbugsm-44873 branch from 34d1cc1 to 538a74b Compare March 2, 2023 18:12

openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 23, 2023

openshift-ci bot assigned trozet Mar 24, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2023

openshift-merge-robot merged commit 0e8ad10 into openshift:master Mar 29, 2023

stbenjam mentioned this pull request Mar 30, 2023

Revert "Make unidle test more strict" #27833

Merged

Conversation

zeeke commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 19, 2023

Uh oh!

zeeke commented Jan 19, 2023

Uh oh!

zeeke commented Jan 19, 2023

Uh oh!

openshift-ci bot commented Feb 2, 2023

Uh oh!

openshift-ci bot commented Feb 23, 2023

Uh oh!

openshift-ci bot commented Mar 2, 2023

Uh oh!

openshift-ci bot commented Mar 2, 2023

Uh oh!

zeeke commented Mar 2, 2023

Uh oh!

zeeke commented Mar 3, 2023

Uh oh!

zeeke commented Mar 23, 2023

Uh oh!

zeeke commented Mar 23, 2023

Uh oh!

zeeke commented Mar 23, 2023

Uh oh!

openshift-ci bot commented Mar 23, 2023

Uh oh!

zeeke commented Mar 23, 2023

Uh oh!

trozet commented Mar 24, 2023

Uh oh!

zeeke commented Mar 27, 2023

Uh oh!

bparees commented Mar 27, 2023

Uh oh!

bparees commented Mar 27, 2023

Uh oh!

openshift-ci bot commented Mar 27, 2023

Uh oh!

openshift-ci-robot commented Mar 27, 2023

Uh oh!

zeeke commented Mar 27, 2023

Uh oh!

bparees commented Mar 27, 2023

Uh oh!

zeeke commented Mar 27, 2023

Uh oh!

zeeke commented Mar 28, 2023

Uh oh!

openshift-ci-robot commented Mar 28, 2023

Uh oh!

zeeke commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2023

Uh oh!

openshift-ci-robot commented Mar 28, 2023

Uh oh!

zeeke commented Mar 29, 2023

Uh oh!

zeeke commented Mar 29, 2023

Uh oh!

openshift-ci bot commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeeke commented Mar 29, 2023

Uh oh!

openshift-ci-robot commented Mar 29, 2023

Uh oh!

stbenjam commented Mar 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

zeeke commented Jan 19, 2023 •

edited

Loading

zeeke commented Mar 28, 2023 •

edited

Loading

openshift-ci bot commented Mar 29, 2023 •

edited

Loading