Skip to content

Conversation

@ardaguclu
Copy link
Member

Currently intervalcreation unit tests assures that the dates with static year(2022) however, logs generated are now in 2023.

This PR fixes that.

Currently intervalcreation unit tests assures that the dates with static
year(2022) however, logs generated are now in 2023.

This PR fixes that.
@openshift-ci openshift-ci bot requested review from csrwng and jwforres January 3, 2023 09:32
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2d22572 and 2 for PR HEAD d1bae3c in total

@ardaguclu
Copy link
Member Author

Changes in this PR has no effect on e2e tests;

/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn d1bae3c link false /test e2e-metal-ipi-sdn
ci/prow/e2e-metal-ipi-ovn-ipv6 d1bae3c link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-etcd-scaling d1bae3c link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-etcd-scaling d1bae3c link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-rt-upgrade d1bae3c link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade d1bae3c link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ea7d4a7 into openshift:master Jan 3, 2023
@ardaguclu ardaguclu deleted the fix-unit-test-year-bug branch January 3, 2023 17:58
@dobsonj
Copy link
Member

dobsonj commented Jan 17, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot

@dobsonj: new pull request created: #27668

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants