-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix intervalcreation incorrect year unit test bug #27630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intervalcreation incorrect year unit test bug #27630
Conversation
Currently intervalcreation unit tests assures that the dates with static year(2022) however, logs generated are now in 2023. This PR fixes that.
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Changes in this PR has no effect on e2e tests; /retest-required |
|
/retest-required |
|
@ardaguclu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.12 |
|
@dobsonj: new pull request created: #27668 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently intervalcreation unit tests assures that the dates with static year(2022) however, logs generated are now in 2023.
This PR fixes that.