Skip to content

Add an upgrade test to verify the migration to AllowedSourceRanges#27458

Closed
suleymanakbas91 wants to merge 1 commit intoopenshift:masterfrom
suleymanakbas91:allowed-source-ranges
Closed

Add an upgrade test to verify the migration to AllowedSourceRanges#27458
suleymanakbas91 wants to merge 1 commit intoopenshift:masterfrom
suleymanakbas91:allowed-source-ranges

Conversation

@suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented Oct 4, 2022 •
edited
Loading

This PR adds an upgrade test to verify the migration from the service.beta.kubernetes.io/load-balancer-source-ranges annotation usage to the new AllowedSourceRanges API.

Epic: https://issues.redhat.com/browse/NE-555
EP: openshift/enhancements#1177
API: openshift/api#1222

  • test/e2e/upgrade/ingress/ingress.go: Implements
    Test interface that includes the following steps:
  1. In Setup, create an IngressController that requests an LB, and set the service.beta.kubernetes.io/load-balancer-source-ranges annotation on the resulting LoadBalancer-type service.
  2. In Test, periodically check the service to verify that nothing updates the annotation or the Spec.LoadBalancerSourceRanges field on the service during the upgrade.
  3. In Test, verify again when the upgrade is done that nothing has updated the annotation or Spec.LoadBalancerSourceRanges, and verify that the operator has set Progressing=True and EvaluationConditionsDetected=True.
  4. Then set AllowedSourceRanges, verify if LoadBalancerSourceRanges is set accordingly, and the annotation is removed. Finally, verify that the operator has set Progressing=False and EvaluationConditionsDetected=False.
  • test/e2e/upgrade/upgrade.go: Adds the new upgrade test to the test suite.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels Oct 14, 2022
@suleymanakbas91 suleymanakbas91 force-pushed the allowed-source-ranges branch 2 times, most recently from df39e57 to aa24358 Compare October 14, 2022 12:45
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 14, 2022

/test all

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 16, 2022

/test e2e-aws-upgrade

2 similar comments
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 16, 2022

/test e2e-aws-upgrade

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 17, 2022

/test e2e-aws-upgrade

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 17, 2022

/test e2e-aws-upgrade

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 17, 2022

/test e2e-gcp-ovn-upgrade
/test e2e-gcp-ovn-rt-upgrade

@suleymanakbas91 suleymanakbas91 changed the title AllowedSourceRanges migration upgrade test NE-1046: Add an upgrade test to verify the migration to AllowedSourceRanges Oct 17, 2022
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 17, 2022

/test e2e-aws-upgrade
/test e2e-gcp-ovn-upgrade
/test e2e-gcp-ovn-rt-upgrade

1 similar comment
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 19, 2022

/test e2e-aws-upgrade
/test e2e-gcp-ovn-upgrade
/test e2e-gcp-ovn-rt-upgrade

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suleymanakbas91
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval by writing /assign @stbenjam in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@suleymanakbas91 suleymanakbas91 force-pushed the allowed-source-ranges branch 2 times, most recently from aef86b8 to 159d311 Compare October 24, 2022 08:48
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 24, 2022

/test all

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 24, 2022

/test e2e-aws-upgrade

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 26, 2022

/test all

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 26, 2022

/test e2e-aws-upgrade

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 26, 2022

/retest

1 similar comment
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Oct 27, 2022

/retest

@suleymanakbas91 suleymanakbas91 changed the title NE-1046: Add an upgrade test to verify the migration to AllowedSourceRanges Add an upgrade test to verify the migration to AllowedSourceRanges Oct 28, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Nov 8, 2022

/test all

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Nov 8, 2022

/test e2e-aws-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

@suleymanakbas91: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brandisher
Copy link

brandisher commented Nov 10, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2022

@suleymanakbas91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-image-ecosystem aa24358 link true /test e2e-gcp-image-ecosystem
ci/prow/e2e-gcp-builds aa24358 link true /test e2e-gcp-builds
ci/prow/e2e-aws-upgrade e224907 link false /test e2e-aws-upgrade
ci/prow/e2e-gcp-ovn-builds e224907 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-image-registry e224907 link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-gcp-ovn-image-ecosystem e224907 link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/e2e-aws-ovn-upgrade 7de1d3e link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 7de1d3e link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 7de1d3e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-ovn 7de1d3e link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-upgrade 7de1d3e link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 7de1d3e link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor Author

suleymanakbas91 commented Dec 2, 2022

We don't need this anymore.

@suleymanakbas91 suleymanakbas91 deleted the allowed-source-ranges branch December 2, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suleymanakbas91 @brandisher @openshift-merge-robot