fix(olm-test): skip test if marketplace is not enabled#27302
Merged
openshift-ci[bot] merged 1 commit intoJul 14, 2022
Merged
Conversation
Contributor
Author
|
/test e2e-gcp-upgrade |
Contributor
Author
|
/test e2e-aws-single-node |
2 similar comments
Contributor
Author
|
/test e2e-aws-single-node |
Contributor
Author
|
/test e2e-aws-single-node |
bparees
reviewed
Jul 13, 2022
anik120
force-pushed
the
skip-olm-test-marketplace-disabled
branch
from
0018b83 to
c4f3974
Compare
Contributor
|
/approve will let someone from olm team give the lgtm |
openshift-ci
Bot
added
the
approved
This PR skips the test `[sig-operator] an end user can use OLM can subscribe to the operator` if marketplace is disabled, since the test uses a default catalogsource included in the cluster by marketplace-operator (which when disabled, results in the absence of the default source) Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
force-pushed
the
skip-olm-test-marketplace-disabled
branch
from
c4f3974 to
f0b3b0a
Compare
Contributor
Author
|
/test e2e-aws-single-node-upgrade |
1 similar comment
Contributor
Author
|
/test e2e-aws-single-node-upgrade |
Contributor
|
@anik120: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, bparees, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/origin
that referenced
this pull request
Aug 2, 2022
…bled Avoid [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-no-capabilities/1554248054456979456 : [sig-operator] an end user can use OLM can subscribe to the operator [Skipped:Disconnected] [Suite:openshift/conformance/parallel] expand_more { fail [github.com/openshift/origin/test/extended/olm/olm.go:270]: Unexpected error: <*json.SyntaxError | 0xc002396318>: { msg: "unexpected end of JSON input", Offset: 0, } unexpected end of JSON input occurred Ginkgo exit error 1: exit with code 1} because the call returns an empty string, and not valid JSON, when the enabledCapabilities property is unset: $ oc get clusterversion version '-o=jsonpath={.status.capabilities}' {"knownCapabilities":["baremetal","marketplace","openshift-samples"]} $ oc get clusterversion version '-o=jsonpath={.status.capabilities.enabledCapabilities}' | wc 0 0 0 Fixing a corner case from f0b3b0a (fix(olm-test): skip test if marketplace is not enabled, 2022-07-12, openshift#27302). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2114506#c0
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Aug 2, 2022
Capabilities are new in 4.11, and CI for them is currently almost passing. But [1] and the not-associated-with-a-bug [2] are fixing a test-case vs. these no-caps clusters which is also broken on 4.11. We could port the test-suite fixes back to 4.11, but with 4.11 about to GA and unlikely to grow new features, we don't expect the periodic to turn up new post-GA breakage, and we do expect unrelated flakes to cause occasional failures and either get ignored or absorb limited triage capacity. This commit drops the 4.11 job, and leaves us flying blind (but likely far above the mountains), and we can revisit if folks decide it is worth budgeting triage time to maintaining and monitoring the 4.11 job. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2114506 [2]: openshift/origin#27302
openshift-ci Bot
pushed a commit
to openshift/release
that referenced
this pull request
Aug 2, 2022
…31011) Capabilities are new in 4.11, and CI for them is currently almost passing. But [1] and the not-associated-with-a-bug [2] are fixing a test-case vs. these no-caps clusters which is also broken on 4.11. We could port the test-suite fixes back to 4.11, but with 4.11 about to GA and unlikely to grow new features, we don't expect the periodic to turn up new post-GA breakage, and we do expect unrelated flakes to cause occasional failures and either get ignored or absorb limited triage capacity. This commit drops the 4.11 job, and leaves us flying blind (but likely far above the mountains), and we can revisit if folks decide it is worth budgeting triage time to maintaining and monitoring the 4.11 job. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2114506 [2]: openshift/origin#27302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips the test
[sig-operator] an end user can use OLM can subscribe to the operatorif marketplace is disabled, since the test uses a default catalogsource included in the cluster by marketplace-operator (which when disabled, results in the absence of the default source)Signed-off-by: Anik Bhattacharjee anikbhattacharya93@gmail.com
See https://issues.redhat.com/browse/OLM-2542 for more details.