Skip to content

Comments

[release-4.9] Bug 2101429: test: switch to testing CapBnd over CapInh#27279

Merged
openshift-ci[bot] merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-27021-to-release-4.9
Jul 8, 2022
Merged

[release-4.9] Bug 2101429: test: switch to testing CapBnd over CapInh#27279
openshift-ci[bot] merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-27021-to-release-4.9

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #27021

/assign haircommander

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2022

@openshift-cherrypick-robot: Bugzilla bug 2076265 has been cloned as Bugzilla bug 2101429. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2101429: test: switch to testing CapBnd over CapInh

Details

In response to this:

[release-4.9] Bug 2076265: test: switch to testing CapBnd over CapInh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2076265: test: switch to testing CapBnd over CapInh [release-4.9] Bug 2101429: test: switch to testing CapBnd over CapInh Jun 27, 2022
@openshift-ci openshift-ci bot requested review from deads2k and knobunc June 27, 2022 13:19
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2101429, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2076265 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2076265 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

[release-4.9] Bug 2101429: test: switch to testing CapBnd over CapInh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

/retest-required

@haircommander
Copy link
Member

/retest

@deads2k @knobunc y'all are listed as approvers, could you PTAL

@haircommander
Copy link
Member

@ashcrow
@bparees
@mfojtik
@knobunc
@ironcladlou
@adambkaplan
@danwinship

PTAL, this will unbreak 4.9 CI/promotion

@bparees
Copy link
Contributor

bparees commented Jun 30, 2022

/approve

@rphillips
Copy link
Contributor

/lgtm

@rphillips
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2022

@rphillips: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@mrunalp mrunalp added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 30, 2022
@stleerh
Copy link

stleerh commented Jun 30, 2022

Is the "ci/prow/okd-e2e-gcp — Job failed." a valid concern?

@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

the test seems not to have provisioned, so I don't think it's related to this PR

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 30, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 1a49193 and 8 for PR HEAD 00aaa7c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 1a49193 and 7 for PR HEAD 00aaa7c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1a49193 and 6 for PR HEAD 00aaa7c in total

@wking
Copy link
Member

wking commented Jul 6, 2022

@wking
Copy link
Member

wking commented Jul 6, 2022

/retest

@wking
Copy link
Member

wking commented Jul 6, 2022

Hmm, maybe I didn't wait long enough, because we failed the same way. Checking the ingress operator:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/27279/pull-ci-openshift-origin-release-4.9-okd-e2e-gcp/1544792718503317504/artifacts/release/artifacts/release-payload-latest/image-references | jq -r '.spec.tags[] | select(.name == "cluster-ingress-operator").annotations["io.openshift.build.commit.id"]'
b59abfcd5bdebcad518ed7bb1ec3581a551c086e

And yeah, we're hoping for openshift/cluster-ingress-operator@9dbf3af5cb7fcc9. Try again:

/retest

as CRI-O will soon drop CapInh, see GHSA-4hj2-r2pm-3hc6 and CVE-2022-27652

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@zaneb zaneb force-pushed the cherry-pick-27021-to-release-4.9 branch from 00aaa7c to 6d05174 Compare July 8, 2022 14:56
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@zaneb
Copy link
Member

zaneb commented Jul 8, 2022

Updated the commit hash to retrigger the CI jobs with hopefully the latest cluster-ingress-operator.

@bparees
Copy link
Contributor

bparees commented Jul 8, 2022

Updated the commit hash to retrigger the CI jobs with hopefully the latest cluster-ingress-operator.

Did we get a confirmation from TP that this is necessary? I guess this situation is somewhat rare, but it's a bit surprising that a retest wouldn't pick up new images from other parts of the payload, when newer images exist. (At a minimum at some point i'd expect the old NS to be deleted and thus the retest, even if it reuses the NS name/hash, would re-import the images and get new versions, but i'm not sure how long the NSes live for)

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, mrunalp, openshift-cherrypick-robot, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jul 8, 2022

Update run failed on the unrelated gcp-pd-csi-driver-controller-... reason/ProbeError Liveness probe error: Get "http://10.0.0.3:10301/healthz": dial tcp 10.0.0.3:10301: connect: connection refused:

/test e2e-gcp-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 6d05174 link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 6ec9a5e into openshift:release-4.9 Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2101429 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2101429: test: switch to testing CapBnd over CapInh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #27306

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.