Skip to content

Enable unidling tests for ovn-k #27226

Closed
oribon wants to merge 2 commits intoopenshift:masterfrom
oribon:ovnk-unidling
Closed

Enable unidling tests for ovn-k #27226
oribon wants to merge 2 commits intoopenshift:masterfrom
oribon:ovnk-unidling

Conversation

@oribon
Copy link
Copy Markdown

@oribon oribon commented Jun 7, 2022

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@openshift-ci openshift-ci bot requested review from mfojtik and sttts June 7, 2022 13:33
@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 8, 2022

/retest

none failed on unidling tests

@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 9, 2022

/retest

none failed on unidling

1 similar comment
@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 9, 2022

/retest

none failed on unidling

@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 9, 2022

/retest

2 similar comments
@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 13, 2022

/retest

@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 13, 2022

/retest

@oribon oribon changed the title WIP: Enable unidling tests for ovn-k Enable unidling tests for ovn-k Jun 14, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2022
@oribon
Copy link
Copy Markdown
Author

oribon commented Jun 22, 2022

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oribon
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval by writing /assign @soltysh in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
oribon added 2 commits November 8, 2022 12:44
@oribon
Update tryEchoHTTP curl cmd
09cebd7 
Curling a service with no endpoints has different results:
openshift-sdn "hangs" while ovn-k rejects immediately.
Because ovk-k refuses the connection curl's retry mechanism
doesn't trigger unless --retry-connrefused is specified.
Adding it allows the initial curl(s) to fail until the endpoints
actually come back from unidling.

Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@oribon
Enable unidling tests for ovn-k
07dd7ff 
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2022
@oribon
Copy link
Copy Markdown
Author

oribon commented Nov 10, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 10, 2022

@oribon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade e5a675c link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-aws-ovn-image-registry e5a675c link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-gcp-ovn-image-ecosystem e5a675c link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/e2e-aws-ovn-single-node-serial 07dd7ff link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-fips 07dd7ff link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-single-node-upgrade 07dd7ff link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-serial 07dd7ff link true /test e2e-aws-ovn-serial
ci/prow/e2e-openstack-ovn 07dd7ff link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oribon
Copy link
Copy Markdown
Author

oribon commented Nov 10, 2022

flake here: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27226/pull-ci-openshift-origin-master-e2e-aws-ovn-fips/1590594274859159552

Run #0: Failed
{  fail [github.com/openshift/origin/test/extended/idling/idling.go:299]: Expected
    <map[string]string | len:3>: {
        "endpoints.kubernetes.io/last-change-trigger-time": "2022-11-10T08:02:36Z",
        "idling.alpha.openshift.io/idled-at": "2022-11-10T08:02:31Z",
        "idling.alpha.openshift.io/unidle-targets": "[{\"kind\":\"DeploymentConfig\",\"name\":\"idling-echo\",\"group\":\"apps.openshift.io\",\"replicas\":2}]",
    }
not to have key
    <string>: idling.alpha.openshift.io/idled-at
Ginkgo exit error 1: exit with code 1}

@oribon
Copy link
Copy Markdown
Author

oribon commented Nov 10, 2022

closing this in favor of #27538

@oribon oribon closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oribon @openshift-merge-robot