Skip to content

Revert "Fix HAProxy tests on FIPS properly"#26979

Merged
deads2k merged 1 commit intoopenshift:masterfrom
stbenjam:revert-26803-BZ2047913-fix-HAProxy-tests-on-FIPS-properly
Apr 7, 2022
Merged

Revert "Fix HAProxy tests on FIPS properly"#26979
deads2k merged 1 commit intoopenshift:masterfrom
stbenjam:revert-26803-BZ2047913-fix-HAProxy-tests-on-FIPS-properly

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 6, 2022

Reverts #26803

This is failing on metal IPv6. Looks like the URI isn't bracketed. It should be created with net.JoinHostPort if possible.

Example from https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-ovn-ipv6/1511378030210060288:

curl -X GET    -s -S -o /tmp/body -D /tmp/headers "http://fd01:0/:0:4::286:1936/healthz" -w '{"code":%{http_code}}' -k 2>/tmp/error 1>/tmp/output || rc=$?

Looks like it's coming from https://github.com/openshift/origin/pull/26803/files#diff-10455b5f6d6375162b49698c75302afcb8944bd5ab6b8d9634c580f67ad799d6R173

When unreverting, please invoke /test e2e-metal-ipi-ovn-ipv6, it's available as an optional job on this repo.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@stbenjam: This pull request references Bugzilla bug 2047913, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "Bug 2047913: Fix HAProxy tests on FIPS properly"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2022

/cc @Miciah @deads2k

@stbenjam stbenjam changed the title Revert "Bug 2047913: Fix HAProxy tests on FIPS properly" Revert "Fix HAProxy tests on FIPS properly" Apr 6, 2022
@openshift-ci openshift-ci bot requested review from Miciah and deads2k April 6, 2022 18:42
@openshift-ci openshift-ci bot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@stbenjam: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert "Fix HAProxy tests on FIPS properly"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from beekhof and gabemontero April 6, 2022 18:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi e635beb link false /test e2e-gcp-csi
ci/prow/e2e-gcp-upgrade e635beb link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-cgroupsv2 e635beb link false /test e2e-aws-cgroupsv2
ci/prow/e2e-gcp-builds e635beb link true /test e2e-gcp-builds
ci/prow/e2e-gcp-ovn-rt-upgrade e635beb link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-single-node-upgrade e635beb link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp e635beb link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k merged commit 41a9cb4 into openshift:master Apr 7, 2022
@stbenjam stbenjam deleted the revert-26803-BZ2047913-fix-HAProxy-tests-on-FIPS-properly branch April 7, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments