Skip to content

Revert "Implementation for basic egressfw e2e CI test"#26967

Merged
deads2k merged 1 commit intoopenshift:masterfrom
DennisPeriquet:revert-26934-eg_fw_ci
Apr 5, 2022
Merged

Revert "Implementation for basic egressfw e2e CI test"#26967
deads2k merged 1 commit intoopenshift:masterfrom
DennisPeriquet:revert-26934-eg_fw_ci

Conversation

@DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Apr 4, 2022

Reverts #26934

A test this PR adds is having a significant impact on jobs: https://search.ci.openshift.org/?search=EgressFirewall+should+have+no+impact+outside+its+namespace&maxAge=48h&context=0&type=bug%2Bjunit&name=periodic&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

$ podman run -it corbinu/alpine-w3m -dump -cols 200 "https://search.ci.openshift.org/?search=EgressFirewall+should+have+no+impact+outside+its+namespace&maxAge=48h&context=0&type=bug%2Bjunit&name=periodic&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job" | grep 'failures match' | sort
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-aws-arm64 (all) - 10 runs, 100% failed, 80% of failures match = 80% impact
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-aws-arm64-techpreview (all) - 10 runs, 100% failed, 50% of failures match = 50% impact
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-aws-ovn-arm64 (all) - 11 runs, 100% failed, 82% of failures match = 82% impact
periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-remote-libvirt-s390x (all) - 4 runs, 100% failed, 25% of failures match = 25% impact
periodic-ci-openshift-multiarch-master-nightly-4.11-upgrade-from-nightly-4.10-ocp-e2e-aws-arm64 (all) - 2 runs, 100% failed, 100% of failures match = 100% impact
periodic-ci-openshift-multiarch-master-nightly-4.11-upgrade-from-stable-4.10-ocp-e2e-aws-arm64 (all) - 2 runs, 100% failed, 100% of failures match = 100% impact
periodic-ci-openshift-release-master-ci-4.11-e2e-aws-ovn (all) - 7 runs, 43% failed, 33% of failures match = 14% impact
periodic-ci-openshift-release-master-ci-4.11-e2e-aws-ovn-upgrade (all) - 113 runs, 98% failed, 4% of failures match = 4% impact
periodic-ci-openshift-release-master-ci-4.11-e2e-azure-ovn (all) - 7 runs, 86% failed, 17% of failures match = 14% impact
periodic-ci-openshift-release-master-ci-4.11-e2e-azure-ovn-upgrade (all) - 70 runs, 100% failed, 1% of failures match = 1% impact
periodic-ci-openshift-release-master-ci-4.11-e2e-azure-upgrade-single-node (all) - 7 runs, 100% failed, 14% of failures match = 14% impact
periodic-ci-openshift-release-master-ci-4.11-e2e-gcp-upgrade (all) - 128 runs, 55% failed, 8% of failures match = 5% impact
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade (all) - 121 runs, 95% failed, 6% of failures match = 6% impact
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-azure-upgrade (all) - 110 runs, 82% failed, 16% of failures match = 13% impact
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade (all) - 70 runs, 89% failed, 5% of failures match = 4% impact
periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-fips (all) - 7 runs, 43% failed, 33% of failures match = 14% impact
periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-proxy (all) - 7 runs, 100% failed, 43% of failures match = 43% impact
periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-upgrade (all) - 77 runs, 71% failed, 4% of failures match = 3% impact
periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp (all) - 7 runs, 57% failed, 50% of failures match = 29% impact
periodic-ci-openshift-release-master-okd-4.11-e2e-aws (all) - 4 runs, 50% failed, 50% of failures match = 25% impact
periodic-ci-openshift-release-master-okd-4.11-e2e-vsphere (all) - 6 runs, 100% failed, 33% of failures match = 33% impact
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.11-e2e-openstack-mapo (all) - 2 runs, 100% failed, 50% of failures match = 50% impact
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.11-e2e-openstack-parallel (all) - 2 runs, 100% failed, 50% of failures match = 50% impact

To unrevert this PR:

Run /payload 4.11 nightly informing three times.
For each attempt, check job/periodic-ci-openshift-release-master-nightly-4.11-e2e-aws-proxy ; your test ([sig-network][Feature:EgressFirewall] EgressFirewall should have no impact outside its namespace [Suite:openshift/conformance/parallel]) must pass all three times.

cc @msherif1234
cc @trozet

@openshift-ci openshift-ci bot requested review from bparees and dmage April 4, 2022 16:13
@DennisPeriquet
Copy link
Contributor Author

/retest

@stbenjam
Copy link
Member

stbenjam commented Apr 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Apr 5, 2022

Is this paired with functionality that landed? if so, that functionality should also be reverted.

forcing this to repair payloads

@deads2k deads2k merged commit 36ddf05 into openshift:master Apr 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2022

@DennisPeriquet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node cff4d32 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments