Skip to content

Ignore FailedCreatePodSandBox event that is expected to happen#26966

Merged
deads2k merged 1 commit intoopenshift:masterfrom
DennisPeriquet:sandbox_ip_alloc
Apr 4, 2022
Merged

Ignore FailedCreatePodSandBox event that is expected to happen#26966
deads2k merged 1 commit intoopenshift:masterfrom
DennisPeriquet:sandbox_ip_alloc

Conversation

@DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Apr 3, 2022 •
edited
Loading

In https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26908/pull-ci-openshift-origin-master-e2e-gcp/1509938673548791808 , we get:

$ cat e2e-events_20220401-174716.json | jq '.items[]|select (.message|test("Error at storage engine: Could not allocate IP in range"))'
{
  "level": "Warning",
  "locator": "ns/e2e-test-whereabouts-e2e-59pln pod/whereabouts-pod-fgf26 node/ci-op-vqn19vmz-2a78c-tgfb2-worker-c-drphp",
  "message": "reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_whereabouts-pod-fgf26_e2e-test-whereabouts-e2e-59pln_3a5636c4-7d4d-4e2c-ad3c-e35ba7bc63df_0(83b31776a78f0592ff291661771cfed6a1af6d718fc348e73b8f73f1fa549c62): error adding pod e2e-test-whereabouts-e2e-59pln_whereabouts-pod-fgf26 to CNI network \"multus-cni-network\": plugin type=\"multus\" name=\"multus-cni-network\" failed (add): [e2e-test-whereabouts-e2e-59pln/whereabouts-pod-fgf26/3a5636c4-7d4d-4e2c-ad3c-e35ba7bc63df:whereaboutstestbridge]: error adding container to network \"whereaboutstestbridge\": Error at storage engine: Could not allocate IP in range: ip: 192.168.2.225 / - 192.168.2.230 / range: net.IPNet{IP:net.IP{0xc0, 0xa8, 0x2, 0xe0}, Mask:net.IPMask{0xff, 0xff, 0xff, 0xf8}}",
  "from": "2022-04-01T18:21:51Z",
  "to": "2022-04-01T18:21:51Z"
}
...

But that is expected because of this test. So, this PR ignores it and does not count it as another FailedCreatePodSandBox failure.

cc @nicklesimba

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2022
@openshift-ci openshift-ci bot requested review from jwforres and mfojtik April 3, 2022 21:38
@DennisPeriquet
Copy link
Contributor Author

DennisPeriquet commented Apr 3, 2022

/retest

1 similar comment
@DennisPeriquet
Copy link
Contributor Author

DennisPeriquet commented Apr 4, 2022

/retest

deads2k
deads2k reviewed Apr 4, 2022
View reviewed changes
pkg/synthetictests/networking.go
if strings.Contains(event.Locator, "pod/whereabouts-pod") &&
strings.Contains(event.Message, "error adding container to network") &&
strings.Contains(event.Message, "Error at storage engine: Could not allocate IP in range: ip: 192.168.2.225 / - 192.168.2.230 ") {
// This failed to create sandbox case is expected due to the whereabouts-e2e test which creates a pod that is expected to
Copy link
Contributor

@deads2k deads2k Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a link to it here please.

@deads2k
Copy link
Contributor

deads2k commented Apr 4, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@DennisPeriquet DennisPeriquet changed the title WIP: Ignore FailedCreatePodSandBox event that is expected to happen Ignore FailedCreatePodSandBox event that is expected to happen Apr 4, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2022
@deads2k
Copy link
Contributor

deads2k commented Apr 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, DennisPeriquet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Apr 4, 2022

failed on leader election. merging to fix the pod sandbox failures.

@deads2k deads2k merged commit 9a8aaff into openshift:master Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

@DennisPeriquet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade f98fd32 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-agnostic-cmd f98fd32 link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@jwforres jwforres Awaiting requested review from jwforres

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DennisPeriquet @deads2k @openshift-bot

Comments