Skip to content

Use ServerGroupResources instead deprecated ServerResources#26956

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:remove-serverresources
Mar 31, 2022
Merged

Use ServerGroupResources instead deprecated ServerResources#26956
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:remove-serverresources

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Mar 31, 2022

ServerResources function was removed in Kubernetes 1.24(ref: kubernetes/kubernetes#107180). This PR changes places to ServerGroupResources to prevent any build errors in bump to 1.24.

@openshift-ci openshift-ci bot requested review from ironcladlou and stlaz March 31, 2022 13:05
@deads2k
Copy link
Contributor

deads2k commented Mar 31, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@stlaz
Copy link
Contributor

stlaz commented Mar 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, deads2k, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 8e99c47 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-single-node 8e99c47 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9772be6 into openshift:master Mar 31, 2022
@ardaguclu ardaguclu deleted the remove-serverresources branch March 31, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants