Skip to content

Bump allowed watches for node-tuning-operator#26944

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:watches
Apr 1, 2022
Merged

Bump allowed watches for node-tuning-operator#26944
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:watches

Conversation

@stbenjam
Copy link
Member

PAO was merged into the node-tuning-operator code (openshift/cluster-node-tuning-operator#322), which seems to have bumped the number of watches used significantly.

New values calculated using this data:

GCP:

$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=gcp\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
  50%   90%   95%  100%
133.0 151.1 159.0 203.0

AWS:

$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=aws\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
  50%   90%   95%  100%
119.0 166.0 168.6 174.0

Metal:

$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=metal\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
   50%    90%    95%   100%
161.50 183.00 191.95 209.00

Azure has no results.

VSphere:

$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=vsphere\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
   50%    90%    95%   100%
113.50 146.80 172.15 175.00

PAO was merged into the node-tuning-operator code, which seems to have
bumped the number of watches used significantly.

New values calculated using this data:

GCP:
```
$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=gcp\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
  50%   90%   95%  100%
133.0 151.1 159.0 203.0
```

AWS:
```
$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=aws\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
  50%   90%   95%  100%
119.0 166.0 168.6 174.0
```

Metal:
```
$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=metal\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
   50%    90%    95%   100%
161.50 183.00 191.95 209.00
```

Azure has no results.

VSphere:

```
$ curl https://search.ci.openshift.org/\?search\=.*Operator.*tuning.*produces+more+watch+requests+than+expected.*\&maxAge\=168h\&context\=1\&type\=junit\&name\=vsphere\&excludeName\=\&maxMatches\=5\&maxBytes\=20971520\&groupBy\=job 2>/dev/null | grep watchrequestcount= | cut -d= -f2 | cut -d, -f1 | Rscript -e 'quantile (as.numeric (readLines ("stdin")), probs=c(0.50,0.90,0.95,1.00))'
   50%    90%    95%   100%
113.50 146.80 172.15 175.00
```
@openshift-ci openshift-ci bot requested review from gabemontero and mfojtik March 28, 2022 17:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@cynepco3hahue
Copy link

/retest

1 similar comment
@MarSik
Copy link
Contributor

MarSik commented Apr 1, 2022

/retest

@deads2k
Copy link
Contributor

deads2k commented Apr 1, 2022

/lgtm

@deads2k
Copy link
Contributor

deads2k commented Apr 1, 2022

/refresh

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@dgoodwin
Copy link
Contributor

dgoodwin commented Apr 1, 2022

/retest

Not sure where the bot is.

@openshift-merge-robot openshift-merge-robot merged commit cf9949f into openshift:master Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants