Migrate tests away from using samples-operator provided imagestreams #26913
Conversation
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
@soltysh ptal for the deployment test changes |
|
/retest |
|
@bparees: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm I'll also /hold to allow the others to chime in. Of course feel free to cancel the hold when you deem it appropriate @bparees |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
| g.It("should run a successful deployment with multiple triggers", func() { | ||
| g.By("creating DC") | ||
|
|
||
| _, err := oc.Run("import-image").Args("registry.redhat.io/ubi8/ruby-30:latest", "--confirm", "--reference-policy=local").Output() |
There was a problem hiding this comment.
Shouldn't we use only images that are mirrored? https://github.com/openshift/origin/blob/master/test/extended/util/image/README.md
There was a problem hiding this comment.
i'm trying to determine the answer to that here:
because many of these tests already weren't using images that were mirrored (this one, for example, was just using the ruby imagestream provided by the samples operator and hosted on registry.redhat.io already).
so this was the minimal change to get away from using that imagestream while still using the same underlying image.
since i'm not confident we should be mirroring images like this (redhat product images), i'm hoping we are allowed use direct references for non-conformance tests.
|
@soltysh any concerns on the deploymentconfig test changes? |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, dmage, gabemontero, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Resolving some of the failures seen in:
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-e2e-aws-no-capabilities/1503711956505202688
which runs our e2e but with optional capabilities (in this case, samples operator)
disabled.