Skip to content

Bug 2047790: Skip some HAProxy tests on FIPS#26800

Merged
deads2k merged 1 commit intoopenshift:masterfrom
Miciah:BZ2047790-skip-some-HAProxy-tests-on-FIPS
Jan 28, 2022
Merged

Bug 2047790: Skip some HAProxy tests on FIPS#26800
deads2k merged 1 commit intoopenshift:masterfrom
Miciah:BZ2047790-skip-some-HAProxy-tests-on-FIPS

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Jan 28, 2022

Skip HAProxy tests that use the router image's built-in default certificate, which is incompatible with FIPS. This is a temporary measure to prevent CI from permafailing on FIPS over the weekend.

  • test/extended/router/scoped.go:
  • test/extended/router/unprivileged.go:
  • test/extended/router/weighted.go: Skip on FIPS.

Skip HAProxy tests that use the router image's built-in default
certificate, which is incompatible with FIPS.  This is a temporary measure
to prevent CI from permafailing on FIPS over the weekend.

This commit is related to bug 2047790.

https://bugzilla.redhat.com/show_bug.cgi?id=2047790

* test/extended/router/scoped.go:
* test/extended/router/unprivileged.go:
* test/extended/router/weighted.go: Skip on FIPS.
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@Miciah: This pull request references Bugzilla bug 2047790, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2047790: Skip some HAProxy tests on FIPS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@openshift-ci openshift-ci bot requested review from frobware and miheer January 28, 2022 20:29
@deads2k
Copy link
Contributor

deads2k commented Jan 28, 2022

/lgtm
/cherrypick release-4.10

@openshift-cherrypick-robot

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Jan 28, 2022

I plan to merge this on a green e2e parallel run and proceed with a pick.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Contributor Author

Miciah commented Jan 28, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@Miciah: This pull request references Bugzilla bug 2047790, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2022
@openshift-ci openshift-ci bot requested a review from lihongan January 28, 2022 20:45
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Jan 28, 2022

e2e gcp mostly worked, e2e-serial failed install, but this doesn't hit that.

@deads2k deads2k merged commit fa696cd into openshift:master Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 2047790 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2047790: Skip some HAProxy tests on FIPS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@Miciah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 786a8ca link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-single-node 786a8ca link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@deads2k: new pull request created: #26802

Details

In response to this:

/lgtm
/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments