Skip to content

Revert "add support for build csi volume source"#26790

Merged
deads2k merged 1 commit intoopenshift:masterfrom
deads2k:revert-csi
Jan 26, 2022
Merged

Revert "add support for build csi volume source"#26790
deads2k merged 1 commit intoopenshift:masterfrom
deads2k:revert-csi

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 26, 2022

This reverts commit 4870fbd.

openshift-tests.[sig-builds][Feature:Builds][volumes] csi build volumes within Tech Preview enabled cluster should mount given csi shared resource secret into the build pod for docker strategy builds
on

  1. https://testgrid.k8s.io/redhat-openshift-ocp-release-4.10-informing#periodic-ci-openshift-release-master-ci-4.10-e2e-azure-techpreview
  2. https://testgrid.k8s.io/redhat-openshift-ocp-release-4.10-informing#periodic-ci-openshift-release-master-nightly-4.10-e2e-vsphere-techpreview
  3. https://testgrid.k8s.io/redhat-openshift-ocp-release-4.10-informing#periodic-ci-openshift-release-master-ci-4.10-e2e-aws-techpreview

are permafailing. They look new and have never passed

they were introduced in #26646

@openshift-ci openshift-ci bot requested review from gabemontero and knobunc January 26, 2022 15:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@yselkowitz
Copy link
Contributor

Note that an actual fix was already posted yesterday as #26783, we just need to confirm that works (which regular E2E testing isn't going to show either way), and that's now in progress.

@gabemontero
Copy link
Contributor

Note that an actual fix was already posted yesterday as #26783, we just need to confirm that works (which regular E2E testing isn't going to show either way), and that's now in progress.

that PR needs more iteration

let's go with this revert to unblock and @jkhelil can sort out these e2e's for tech preview function separately.

we have had sufficient manual verification on this feature.

@gabemontero
Copy link
Contributor

/lgtm

@gabemontero
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@deads2k
Copy link
Contributor Author

deads2k commented Jan 26, 2022

we are going with this revert. more problems were uncovered by the /payload command.

@deads2k deads2k merged commit 9be1cf0 into openshift:master Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments