adds a synthetic test for checking if the pod.spec.nodeName field is immutable#26772
Conversation
|
/assign @deads2k |
p0lyn0mial
force-pushed
the
check-pod-nodeName-immutability
branch
from
ad4e036 to
21bd96d
Compare
|
@p0lyn0mial: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| conditions = append(conditions, monitorapi.Condition{ | ||
| Level: monitorapi.Error, | ||
| Locator: locatePod(pod), | ||
| Message: fmt.Sprintf("invariant violation, pod once assigned to a node must stay on it. The pod previously scheduled to %s, has just been assigned to a new node %s", oldPod.Spec.NodeName, pod.Spec.NodeName), |
There was a problem hiding this comment.
nit: if this gets cleared, you will constantly wonder what that nodename is. I suggest
- include the resourceversion for old and new.
- use %q for your node names
- inspect the field owners in metadata for old and new to determine who overwrite the value.
|
this is significantly better than what we have. I think my suggestions are good/valuable, but if you aren't going to get to them, you can release the hold /lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
deads2k
added
the
bugzilla/valid-bug
|
trying to work out the scope of our problem, bypassing bug requirement |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
looks like he's out. This is strictly better than nothing. merging. |
2 participants
a simple monitor test for checking immutability of
pod.spec.nodeNamefield.The field is not allowed to change once set i.e. a pod assigned to a node must stay on it.
It will help gather more data (if any) for https://bugzilla.redhat.com/show_bug.cgi?id=2042657