Bug 2038481: Flake failed sandboxes from bug in new guard pods#26763
Bug 2038481: Flake failed sandboxes from bug in new guard pods#26763jluhrsen wants to merge 1 commit intoopenshift:masterfrom
Conversation
more info in https://bugzilla.redhat.com/show_bug.cgi?id=2038481 essentially, two new guard pods are being started in 4.10+ and are incorrectly being restarted on a cordoned node and when the node is rebooted those pods fail to set up sandboxes right away before the underlying network config file is present. This can be reverted when the PR to fix this is merged: openshift/library-go#1287 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
@jluhrsen: This pull request references Bugzilla bug 2038481, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/assign @spadgett |
|
/hold |
|
@jluhrsen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
right, I had assumed the "real fix" was all that was needed. Actually it was just the foundation in library-go that needed to go I will check in on those and if they don't look like they'll be merged in a timely fashion (I get the sense they will be), |
|
The explanation in the bugs makes sense. /lgtm verify failure is real. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dgoodwin, jluhrsen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jluhrsen: This pull request references Bugzilla bug 2038481. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
merged in #26776 |
more info in https://bugzilla.redhat.com/show_bug.cgi?id=2038481
essentially, two new guard pods are being started in 4.10+ and
are incorrectly being restarted on a cordoned node and when the
node is rebooted those pods fail to set up sandboxes right away
before the underlying network config file is present. This can
be reverted when the PR to fix this is merged:
openshift/library-go#1287
Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com