Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #26629

/assign wking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

@openshift-cherrypick-robot: Bugzilla bug 2025088 has been cloned as Bugzilla bug 2025724. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 2025724: Add admin ack Upgradeable condition gate test

Details

In response to this:

[release-4.8] Bug 2025088: Add admin ack Upgradeable condition gate test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 2025088: Add admin ack Upgradeable condition gate test [release-4.8] Bug 2025724: Add admin ack Upgradeable condition gate test Nov 22, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2025724, which is invalid:

  • expected dependent Bugzilla bug 2025088 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.8] Bug 2025724: Add admin ack Upgradeable condition gate test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 22, 2021
@openshift-ci openshift-ci bot requested review from deads2k and dmage November 22, 2021 20:13
@wking
Copy link
Member

wking commented Nov 23, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

@wking: This pull request references Bugzilla bug 2025724, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2025088 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2025088 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianlinliu November 23, 2021 04:34
@wking
Copy link
Member

wking commented Nov 23, 2021

upgrade (and rollback) job was looking good; it just ran out of time and got the 4h TERM mid-deprovision. e2e-aws got bit by rhbz#2025742 pre-test suite. e2e-agnostic-cmd hit an auth error during test-cmd: test/cmd/triggers.sh. None of those failures seem related to this PR, but I'm not going to call for retests until we collect lgtm, approved, backport-risk-assessed, or cherry-pick-approved (although if the folks responsible for those labels want to call for retests, that's completely fine with me).

@sdodson
Copy link
Member

sdodson commented Nov 29, 2021

/lgtm
/approve

@sdodson sdodson added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Nov 29, 2021

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 201e1e7 into openshift:release-4.8 Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2025724 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 2025724: Add admin ack Upgradeable condition gate test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants