Skip to content

Comments

Bug 1996097: Skip renamed dualstack tests in OVNKubernetes#26414

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:skip-renamed-tests-ovnkubernetes
Aug 21, 2021
Merged

Bug 1996097: Skip renamed dualstack tests in OVNKubernetes#26414
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ardaguclu:skip-renamed-tests-ovnkubernetes

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Aug 20, 2021

Previously skipped dualstack tests(#26241) have been renamed after the latest bump.
This PR adds renamed tests into OVN-K skipped list for dualstack.

@ardaguclu ardaguclu changed the title Skipped renamed dualstack tests in OVNKubernetes Skip renamed dualstack tests in OVNKubernetes Aug 20, 2021
@ardaguclu
Copy link
Member Author

/e2e-metal-ipi-ovn-dualstack

@ardaguclu
Copy link
Member Author

/e2e-metal-ipi-ovn-dualstack

`\[sig-network\] \[Feature:IPv6DualStack\] \[LinuxOnly\] Granular Checks: Services Secondary IP Family should function for client IP based session affinity: http`,
`\[sig-network\] \[Feature:IPv6DualStack\] \[LinuxOnly\] Granular Checks: Services Secondary IP Family should function for client IP based session affinity: udp`,
`\[sig-network\] \[Feature:IPv6DualStack\] \[LinuxOnly\] should have ipv4 and ipv6 node podCIDRs`,
`\[sig-network\] \[Feature:IPv6DualStack\] Granular Checks: Services Secondary IP Family \[LinuxOnly\] should function for client IP based session affinity: http`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bug referenced for this skip set is verified and the jira referenced for this block has its PR merged. Why are we still skipping these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deads2k. I think, referenced PR in jira has been merged in upstream ovn-kubernetes/ovn-kubernetes#2294 but not in downstream openshift/ovn-kubernetes#666.

Since service affinity is not supported, bug was verified after skipping these three tests for OVN-K.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service affinity should work once 666 merges. The only thing that isnt supported is:
https://github.com/ovn-org/ovn-kubernetes/blob/master/test/scripts/e2e-kind.sh#L30

Previously skipped dualstack tests have been renamed after the latest bump.
This PR adds renamed tests into OVN-K skipped list for dualstack.
@ardaguclu ardaguclu force-pushed the skip-renamed-tests-ovnkubernetes branch from 2cd269a to 31d31f4 Compare August 20, 2021 14:38
@ardaguclu ardaguclu changed the title Skip renamed dualstack tests in OVNKubernetes Bug 1996097: Skip renamed dualstack tests in OVNKubernetes Aug 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2021

@ardaguclu: This pull request references Bugzilla bug 1996097, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1996097: Skip renamed dualstack tests in OVNKubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2021
@ardaguclu
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2021

@ardaguclu: This pull request references Bugzilla bug 1996097, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Aug 20, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
@ardaguclu
Copy link
Member Author

@danwinship could you please take a look at?. Thanks.

@ardaguclu
Copy link
Member Author

/retest-required

@dcbw
Copy link
Contributor

dcbw commented Aug 21, 2021

/lgtm
/override ci/prow/e2e-aws-serial
(test has nothing to do with dual-stack since it's an SDN test, and dual-stack is OVN-only)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2021
@dcbw
Copy link
Contributor

dcbw commented Aug 21, 2021

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@dcbw: dcbw unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

/lgtm
/override ci/prow/e2e-aws-serial
(test has nothing to do with dual-stack since it's an SDN test, and dual-stack is OVN-only)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, dcbw, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd 31d31f4 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-single-node 31d31f4 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4e341eb into openshift:master Aug 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@ardaguclu: All pull requests linked via external trackers have merged:

Bugzilla bug 1996097 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1996097: Skip renamed dualstack tests in OVNKubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the skip-renamed-tests-ovnkubernetes branch January 25, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants