Skip to content

Conversation

@xiuwang
Copy link
Contributor

@xiuwang xiuwang commented Jul 22, 2021

@gabemontero The auto trigger always make sample-pipeline failed. Please help reivew this

@openshift-ci openshift-ci bot requested review from jupierce and waveywaves July 22, 2021 08:29
@gabemontero
Copy link
Contributor

@xiuwang you have to run make update when changing json or yaml in the tests to update bindata.go

@gabemontero
Copy link
Contributor

Also, any chance you have some sample output when it fails? At first blush I would say it does not "always" fail as this particular sample is exercised in the e2e's

@xiuwang
Copy link
Contributor Author

xiuwang commented Jul 23, 2021

Thanks Gabe.
Sample-pipeline always failed.
$ oc get builds -n wxj1
NAME TYPE FROM STATUS STARTED DURATION
nodejs-postgresql-example-1 Source Git@93a4c44 Complete 2 hours ago 1m49s
sample-pipeline-1 JenkinsPipeline Failed 2 hours ago
nodejs-postgresql-example-2 Source Git@93a4c44 Complete 2 hours ago 1m26s

[rollout:latest:deploymentconfig/nodejs-postgresql-example] error: #2 is already in progress (Pending).
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // timeout
[Pipeline] echo
in catch block
[Pipeline] echo
Caught: hudson.AbortException: rollout:latest returned an error;
{err=error: #2 is already in progress (Pending).
, verb=rollout, cmd=oc --server=https://172.30.0.1:443 --certificate-authority=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt --namespace=wxj1 --token=XXXXX rollout latest deploymentconfig/nodejs-postgresql-example , out=, status=1}

[Pipeline] End of Pipeline
ERROR: rollout:latest returned an error;
{err=error: #2 is already in progress (Pending).
, verb=rollout, cmd=oc --server=https://172.30.0.1:443 --certificate-authority=/var/run/secrets/kubernetes.io/serviceaccount/ca.crt --namespace=wxj1 --token=XXXXX rollout latest deploymentconfig/nodejs-postgresql-example , out=, status=1}

Finished: FAILURE

@gabemontero
Copy link
Contributor

thanks @xiuwang

And I see now, while we "use" that bc, we don't start builds with it. We use it for our delete bc / delete job test.

That said, as I'm in the process of moving the jenkins e2e's, and we have a longer term goal of removing the examples/jenkins stuff, we'll just go with your fix for now.

e2e's are green, so I'll

/lgtm

but we'll need

@adambkaplan

to approve given we had to update bindata

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@gabemontero
Copy link
Contributor

/assign @adambkaplan

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 394775d into openshift:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants