-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Remove auto trigger #26345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove auto trigger #26345
Conversation
|
@xiuwang you have to run |
|
Also, any chance you have some sample output when it fails? At first blush I would say it does not "always" fail as this particular sample is exercised in the e2e's |
|
Thanks Gabe. [rollout:latest:deploymentconfig/nodejs-postgresql-example] error: #2 is already in progress (Pending). [Pipeline] End of Pipeline Finished: FAILURE |
|
thanks @xiuwang And I see now, while we "use" that bc, we don't start builds with it. We use it for our delete bc / delete job test. That said, as I'm in the process of moving the jenkins e2e's, and we have a longer term goal of removing the examples/jenkins stuff, we'll just go with your fix for now. e2e's are green, so I'll /lgtm but we'll need to approve given we had to update bindata |
|
/assign @adambkaplan |
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero, xiuwang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gabemontero The auto trigger always make sample-pipeline failed. Please help reivew this