Update quickstart examples and re-run make update by stbenjam · Pull Request #26300 · openshift/origin

stbenjam · 2021-07-01T18:55:53Z

Remove dotnet examples from quickstarts, as they were removed upstream.

In this PR:

Remove dotnet from quickstarts/examples README.md
Run ./hack/update-external-examples.sh
Run make update

Currently, the dotnet files aren't valid JSON and causing tests to fail
in this repo.

Remove dotnet examples from quickstarts, as they were removed upstream. In this PR: - Remove dotnet from quickstarts/examples README.md - Run ./hack/update-external-examples.sh - Run make update Currently, the dotnet files aren't valid JSON and causing tests to fail in this repo.

yselkowitz · 2021-07-01T19:36:54Z

This slipped through during #26072 because hack/verify-jsonformat.sh is apparently not fatal to the verify E2E job. The script shows this is clean, and this follows the (now working again) procedure for updating embedded samples.
/lgtm
/assign @gabemontero @adambkaplan

gabemontero · 2021-07-01T19:52:48Z

I don't have authority to approve any of this @yselkowitz @stbenjam

@adambkaplan who you have assigned does

but everything articulated here SGTM

yselkowitz · 2021-07-02T15:57:56Z

/retest

yselkowitz · 2021-07-04T03:20:41Z

/retest

yselkowitz · 2021-07-06T19:09:53Z

/assign @bparees

bparees · 2021-07-06T21:27:24Z

/approve

openshift-ci · 2021-07-06T21:27:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, stbenjam, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~examples/image-streams/OWNERS~~ [bparees]
~~examples/quickstarts/OWNERS~~ [bparees]
~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-06T23:26:52Z

/retest