Skip to content

Comments

builds: comment out RHEL-only sample-pipeline template test#26278

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
yselkowitz:ubi8
Jun 29, 2021
Merged

builds: comment out RHEL-only sample-pipeline template test#26278
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
yselkowitz:ubi8

Conversation

@yselkowitz
Copy link
Contributor

This test relies on pulling yaml from github rather than from bindata,
which makes it difficult to pre-commit testing of changes which affect
it. @akram and @gabemontero will move this to the jenkins client plugin
E2E, but in the meantime, we comment it out.

#26072 (comment)

/cc @gabemontero

This test relies on pulling yaml from github rather than from bindata,
which makes it difficult to pre-commit testing of changes which affect
it.  @akram and @gabemontero will move this to the jenkins client plugin
E2E, but in the meantime, we comment it out.

openshift#26072 (comment)
@gabemontero
Copy link
Contributor

/lgtm

some further clarification - this RHEL only file is the intended regression testing subset to run on multi arch to sniff test jenkins on those arch's, where we only use images based on RHEL (which is a restriction we do not have on x86)

the remaining set of tests here are still a sufficient sniff test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 28, 2021
@yselkowitz
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6cffc3a into openshift:master Jun 29, 2021
@yselkowitz yselkowitz deleted the ubi8 branch October 5, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants