Bug 1983614: Add renamed Prometheus test into skipped disconnected list#26261
Conversation
|
/retest |
|
/test e2e-gcp |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
I lack some background here. Why should alerts be allowed to fire in the disconnected case? If we can detect this, why not simply determine which alerts can fire as opposed to those that shouldn't? |
|
@deads2k, tests under the ICSP section try to pull As you said, if it did not have any image pull problem, it would be expected to not fire alerts even in disconnected. |
ardaguclu
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@ardaguclu: This pull request references Bugzilla bug 1983614, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| `\[sig-instrumentation\]\[Late\] Alerts should have a Watchdog alert in firing state the entire cluster run`, | ||
| `\[sig-instrumentation\]\[Late\] Alerts shouldn't exceed the 500 series limit of total series sent via telemetry from each cluster`, | ||
| `\[sig-instrumentation\]\[Late\] Alerts shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured`, | ||
| `\[sig-instrumentation\]\[Late\] Alerts shouldn't report any alerts in firing or pending state apart from Watchdog and AlertmanagerReceiversNotConfigured and have no gaps in Watchdog firing`, |
There was a problem hiding this comment.
Are we still firing alerts in disconnected mode? Or is this because we can't access the test? This is such a fundamental safety net that the fact that we shipped 4.8 with this failing means we have a huge knowledge gap as to whether disconnected is safe.
Is there a story covering reenabling this test because "we've fixed this"? I see there's a comment up above for "ICSP" - isn't that bug fixed? In the future, please add bugzilla links to these sections that have a bug we can track for "this problem is now fixed".
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, ardaguclu, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@ardaguclu: All pull requests linked via external trackers have merged: Bugzilla bug 1983614 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.8 |
|
@ardaguclu: new pull request created: #26344 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
This PR updates
Skipped:Disconnectedlist with the renamed test.Previously;
[sig-instrumentation][Late] Alerts shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfiguredCurrently;
[sig-instrumentation][Late] Alerts shouldn't report any alerts in firing or pending state apart from Watchdog and AlertmanagerReceiversNotConfigured and have no gaps in Watchdog firing