Bug 1971590: Enable TestEndpointAdmission test only for OpenShift SDN by ardaguclu · Pull Request #26223 · openshift/origin

ardaguclu · 2021-06-14T11:32:34Z

This PR applies only enabling TestEndpointAdmission test for OpenShift SDN

openshift-ci · 2021-06-14T11:32:38Z

@ardaguclu: This pull request references Bugzilla bug 1971590, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1971590: Add IPv6 endpoint for TestEndpointAdmission test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ardaguclu · 2021-06-14T13:47:18Z

/retest

ardaguclu · 2021-06-14T14:52:14Z

/bugzilla refresh

openshift-ci · 2021-06-14T14:53:21Z

@ardaguclu: This pull request references Bugzilla bug 1971590, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ardaguclu · 2021-06-14T16:12:55Z

/retest

dcbw · 2021-06-14T20:33:26Z

test/extended/networking/endpoint_admission.go

-	"cluster":  "10.128.0.2",
-	"service":  "172.30.0.2",
-	"external": "1.2.3.4",
+var exampleServiceAddresses = map[string]string{


@ardaguclu I would move this into the TestEndpointAdmission() function since it's only used there and it's confusing to have it as a global when testOne() also creates a map of the same name, but in local scope.

In fact, why even bother with the map? Why not just assign the addresses directly since exampleServiceAddresses is only used in one place?

Thanks for review @dcbw, I changed according to your suggestions.

ardaguclu · 2021-06-18T17:27:32Z

/retest

ardaguclu · 2021-06-21T08:41:33Z

/test e2e-aws-csi

danwinship

There was discussion about this test somewhere else but I don't remember where.

This is only relevant for openshift-sdn in Multitenant mode, and thus there's no need to test it under IPv6. The test should just be wrapped in InOpenShiftSDNContext() so it gets skipped for other plugins.

ardaguclu · 2021-06-25T12:43:01Z

Thanks @danwinship, I did changes and only enable this test for OpenShift sdn is enabled cases.

ardaguclu · 2021-06-29T09:50:59Z

/retest

openshift-ci · 2021-06-29T10:12:41Z

@ardaguclu: This pull request references Bugzilla bug 1971590, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1971590: Enable TestEndpointAdmission test only for OpenShift SDN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ardaguclu · 2021-06-29T12:39:55Z

/retest

ardaguclu · 2021-07-09T06:51:09Z

/retest

danwinship · 2021-07-13T17:20:38Z

test/extended/networking/endpoint_admission.go

-	g.It("TestEndpointAdmission", func() {
-		TestEndpointAdmission(g.GinkgoT(), oc)
+	InOpenShiftSDNContext(func() {
+		g.It("TestEndpointAdmission", func() {


maybe clarify that while we're here

g.It("blocks manual creation of Endpoints pointing to the cluster or service network", func() {

Done. Thanks.

ardaguclu · 2021-07-19T07:52:05Z

/retest

danwinship · 2021-07-19T14:17:29Z

/lgtm

ardaguclu · 2021-07-26T11:15:04Z

/test e2e-gcp-upgrade

danwinship · 2021-07-26T13:39:27Z

/assign @knobunc

knobunc · 2021-07-26T14:59:09Z

/approve

openshift-ci · 2021-07-26T14:59:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, danwinship, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/networking/OWNERS~~ [danwinship,knobunc]
~~test/extended/util/annotate/OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ardaguclu · 2021-07-26T15:17:00Z

/retest

openshift-bot · 2021-07-26T16:14:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-26T17:49:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

ardaguclu · 2021-07-26T17:50:01Z

/retest-required

openshift-ci · 2021-07-26T22:44:09Z

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-disruptive	`42eae84`	link	`/test e2e-gcp-disruptive`
ci/prow/e2e-aws-disruptive	`42eae84`	link	`/test e2e-aws-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-07-26T23:00:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-27T01:12:59Z

@ardaguclu: All pull requests linked via external trackers have merged:

openshift/origin#26223

Bugzilla bug 1971590 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1971590: Enable TestEndpointAdmission test only for OpenShift SDN

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ardaguclu · 2021-07-27T05:38:31Z

/cherrypick release-4.8

openshift-cherrypick-robot · 2021-07-27T05:41:18Z

@ardaguclu: new pull request created: #26351

Details

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 14, 2021

openshift-ci bot requested review from dcbw and squeed June 14, 2021 11:32

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 14, 2021

dcbw reviewed Jun 14, 2021

View reviewed changes

ardaguclu force-pushed the fix-testadmission-ipv6 branch from 42eae84 to ea77745 Compare June 15, 2021 07:20

danwinship suggested changes Jun 25, 2021

View reviewed changes

ardaguclu force-pushed the fix-testadmission-ipv6 branch 2 times, most recently from 5e62e23 to e993ed3 Compare June 25, 2021 12:41

ardaguclu changed the title ~~Bug 1971590: Add IPv6 endpoint for TestEndpointAdmission test~~ Bug 1971590: Enable TestEndpointAdmission test only for OpenShift SDN Jun 25, 2021

danwinship approved these changes Jul 13, 2021

View reviewed changes

Enable TestEndpointAdmission test only for OpenShift SDN

7385524

ardaguclu force-pushed the fix-testadmission-ipv6 branch from e993ed3 to 7385524 Compare July 14, 2021 05:30

openshift-ci bot assigned danwinship Jul 19, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021

openshift-ci bot assigned knobunc Jul 26, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021

openshift-merge-robot merged commit 9efa552 into openshift:master Jul 27, 2021

openshift-cherrypick-robot mentioned this pull request Jul 27, 2021

[release-4.8] Bug 1986259: Enable TestEndpointAdmission test only for OpenShift SDN #26351

Merged

ardaguclu mentioned this pull request Sep 12, 2021

Enable skipped tests in disconnected for connected workflows openshift/release#21771

Merged

ardaguclu deleted the fix-testadmission-ipv6 branch January 25, 2022 08:27

Conversation

ardaguclu commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jun 14, 2021

Uh oh!

ardaguclu commented Jun 14, 2021

Uh oh!

ardaguclu commented Jun 14, 2021

Uh oh!

openshift-ci bot commented Jun 14, 2021

Uh oh!

ardaguclu commented Jun 14, 2021

Uh oh!

dcbw Jun 14, 2021

Choose a reason for hiding this comment

Uh oh!

dcbw Jun 14, 2021

Choose a reason for hiding this comment

Uh oh!

ardaguclu Jun 15, 2021

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Jun 18, 2021

Uh oh!

ardaguclu commented Jun 21, 2021

Uh oh!

danwinship left a comment

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Jun 25, 2021

Uh oh!

ardaguclu commented Jun 29, 2021

Uh oh!

openshift-ci bot commented Jun 29, 2021

Uh oh!

ardaguclu commented Jun 29, 2021

Uh oh!

ardaguclu commented Jul 9, 2021

Uh oh!

danwinship Jul 13, 2021

Choose a reason for hiding this comment

Uh oh!

ardaguclu Jul 14, 2021

Choose a reason for hiding this comment

Uh oh!

ardaguclu commented Jul 19, 2021

Uh oh!

danwinship commented Jul 19, 2021

Uh oh!

ardaguclu commented Jul 26, 2021

Uh oh!

danwinship commented Jul 26, 2021

Uh oh!

knobunc commented Jul 26, 2021

Uh oh!

openshift-ci bot commented Jul 26, 2021

Uh oh!

ardaguclu commented Jul 26, 2021

Uh oh!

openshift-bot commented Jul 26, 2021

Uh oh!

openshift-bot commented Jul 26, 2021

Uh oh!

ardaguclu commented Jul 26, 2021

Uh oh!

openshift-ci bot commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Jul 26, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

ardaguclu commented Jul 27, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 27, 2021

Uh oh!

Reviewers

Assignees

Labels

ardaguclu commented Jun 14, 2021 •

edited

Loading

openshift-ci bot commented Jul 26, 2021 •

edited

Loading