Skip to content

tests/extended: Add a basic sanity test for CoreOS bootimages #25993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 1, 2021
Merged

tests/extended: Add a basic sanity test for CoreOS bootimages #25993

openshift-merge-robot merged 1 commit into from
Apr 1, 2021

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Mar 19, 2021

This validates openshift/installer#4760
until we have an in-cluster consumer.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cgwalters cgwalters mentioned this pull request Mar 19, 2021
Merged
@cgwalters
Copy link
Member Author

cgwalters commented Mar 19, 2021

Requires: openshift/installer#4760

@cgwalters cgwalters force-pushed the test-coreos-bootimages branch from a36be93 to 3c87f33 Compare March 19, 2021 21:03
@cgwalters
Copy link
Member Author

cgwalters commented Mar 26, 2021

And that PR merged, lifting draft!

@cgwalters cgwalters marked this pull request as ready for review March 26, 2021 11:35
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021
@cgwalters cgwalters force-pushed the test-coreos-bootimages branch from 3c87f33 to 43a626a Compare March 26, 2021 13:17
@cgwalters cgwalters force-pushed the test-coreos-bootimages branch from 43a626a to 5b62c32 Compare March 26, 2021 13:35
@cgwalters
Copy link
Member Author

cgwalters commented Mar 26, 2021

/test e2e-gcp

@cgwalters
Copy link
Member Author

cgwalters commented Mar 26, 2021

Hooray, test passed in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25993/pull-ci-openshift-origin-master-e2e-aws-fips/1375441398135787520

@ashcrow
Copy link
Member

ashcrow commented Mar 26, 2021

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021
@ashcrow
Copy link
Member

ashcrow commented Mar 26, 2021

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 26, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 26, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Member Author

cgwalters commented Mar 26, 2021

Mmm tempting to ask for an /override ci/prow/e2e-metal-ipi-ovn-ipv6 since it really feels like it can't affect metal but OTOH maybe somehow it can, so let's just wait while that's debugged and fixed.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 27, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 28, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Member Author

cgwalters commented Mar 28, 2021

/hold
until the metal test is debugged and fixed.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2021
@cgwalters
Copy link
Member Author

cgwalters commented Mar 30, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@cgwalters
Copy link
Member Author

cgwalters commented Mar 30, 2021

/test e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 31, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Member Author

cgwalters commented Mar 31, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9aebec6 into openshift:master Apr 1, 2021
@mike-nguyen mike-nguyen mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow ashcrow approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@ashcrow ashcrow

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cgwalters @openshift-ci-robot @ashcrow @openshift-bot @openshift-merge-robot