test: stop building URL's with host/port and Sprintf#25987
test: stop building URL's with host/port and Sprintf#25987smarterclayton merged 1 commit intoopenshift:masterfrom
Conversation
You cannot build host:port in a URL with a simple Sprintf due to IPv6, otherwise you'll produce invalid URL's. This moves to using net.JoinHostPort to build URL's instead.
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
We also need openshift/kubernetes#628 |
|
/lgtm |
|
Looks like everything passed, clearing the queue. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You cannot build host:port in a URL with a simple Sprintf due to IPv6,
otherwise you'll produce invalid URL's. This moves to using
net.JoinHostPort to build URL's instead.