Skip to content

test: stop building URL's with host/port and Sprintf#25987

Merged
smarterclayton merged 1 commit intoopenshift:masterfrom
stbenjam:fix-ipv6-urls
Mar 19, 2021
Merged

test: stop building URL's with host/port and Sprintf#25987
smarterclayton merged 1 commit intoopenshift:masterfrom
stbenjam:fix-ipv6-urls

Conversation

@stbenjam
Copy link
Member

You cannot build host:port in a URL with a simple Sprintf due to IPv6,
otherwise you'll produce invalid URL's. This moves to using
net.JoinHostPort to build URL's instead.

You cannot build host:port in a URL with a simple Sprintf due to IPv6,
otherwise you'll produce invalid URL's. This moves to using
net.JoinHostPort to build URL's instead.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2021

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-disruptive 14a416c link /test e2e-aws-disruptive
ci/prow/e2e-aws-serial 14a416c link /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade 14a416c link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member Author

We also need openshift/kubernetes#628

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2021
@smarterclayton
Copy link
Contributor

Looks like everything passed, clearing the queue.

@smarterclayton smarterclayton merged commit d3fd4e8 into openshift:master Mar 19, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2021
@stbenjam stbenjam deleted the fix-ipv6-urls branch March 20, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants