Skip to content

Allow several alerts in single replica topology #25936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
omertuc wants to merge 1 commit into from
Closed

Allow several alerts in single replica topology #25936

omertuc wants to merge 1 commit into from

Conversation

@omertuc
Copy link
Contributor

@omertuc omertuc commented Mar 4, 2021 •
edited
Loading

EDIT:
This PR used to be just for MON-1522, but now it's also for https://bugzilla.redhat.com/show_bug.cgi?id=1945017 and API-1136

@romfreiman
Copy link

romfreiman commented Mar 4, 2021

/lgtm
Can u please connect it to the jira ticket as a workaround?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omertuc, romfreiman
To complete the pull request process, please assign squat after the PR has been reviewed.
You can assign the PR to them by writing /assign @squat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@romfreiman
Copy link

romfreiman commented Mar 4, 2021

@smarterclayton wdyt? Temporary till it will be fixed on the product level. Otherwise we cannot enable sno ci

@omertuc
Copy link
Contributor Author

omertuc commented Mar 4, 2021

Can u please connect it to the jira ticket as a workaround?

That's done automatically when the issue is referenced, but commented anyway

@omertuc
Copy link
Contributor Author

omertuc commented Mar 4, 2021

/test e2e-agnostic-cmd

/test e2e-gcp-upgrade

/test e2e-gcp

@omertuc
Copy link
Contributor Author

omertuc commented Mar 4, 2021

/test e2e-agnostic-cmd
/test e2e-aws-fips
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-upgrade
/test e2e-metal-ipi-ovn-ipv6

@romfreiman
Copy link

romfreiman commented Mar 4, 2021

/test e2e-aws-fips

@romfreiman
Copy link

romfreiman commented Mar 4, 2021

/test e2e-aws-single-node

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2021

@romfreiman: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test images
  • /test okd-e2e-gcp
  • /test verify
  • /test verify-deps
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-disruptive
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-disruptive
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test e2e-aws-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@romfreiman
Copy link

romfreiman commented Mar 4, 2021

/test ?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2021

@romfreiman: The following commands are available to trigger jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test images
  • /test okd-e2e-gcp
  • /test verify
  • /test verify-deps
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-disruptive
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-disruptive
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smarterclayton
smarterclayton reviewed Mar 8, 2021
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 8, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 8, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Mar 8, 2021

/test e2e-metal-ipi-ovn-ipv6
/test e2e-aws-csi
/test e2e-gcp-upgrade

@omertuc
Copy link
Contributor Author

omertuc commented Mar 9, 2021

/test e2e-aws-disruptive
/test e2e-aws-serial
/test e2e-gcp-upgrade
/test e2e-gcp-disruptive

@omertuc
Copy link
Contributor Author

omertuc commented Mar 9, 2021

/test e2e-aws-serial
/test e2e-gcp-disruptive

1 similar comment
@omertuc
Copy link
Contributor Author

omertuc commented Mar 10, 2021

/test e2e-aws-serial
/test e2e-gcp-disruptive

@omertuc
Copy link
Contributor Author

omertuc commented Mar 10, 2021

/test e2e-gcp-disruptive

@omertuc
Copy link
Contributor Author

omertuc commented Mar 10, 2021

/test e2e-aws-disruptive

@omertuc
Copy link
Contributor Author

omertuc commented Mar 10, 2021

/test e2e-aws-serial

@sinnykumari sinnykumari mentioned this pull request Mar 11, 2021
Merged
@omertuc
Copy link
Contributor Author

omertuc commented Mar 11, 2021

/test e2e-aws-serial

1 similar comment
@romfreiman
Copy link

romfreiman commented Mar 11, 2021

/test e2e-aws-serial

@romfreiman
Copy link

romfreiman commented Mar 11, 2021

/test e2e-aws-disruptive

@romfreiman
Copy link

romfreiman commented Mar 13, 2021

/test e2e-aws-serial

@romfreiman
Copy link

romfreiman commented Mar 13, 2021

/test ?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2021

@romfreiman: The following commands are available to trigger jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test images
  • /test okd-e2e-gcp
  • /test verify
  • /test verify-deps
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-disruptive
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-disruptive
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@romfreiman
Copy link

romfreiman commented Mar 13, 2021

/test e2e-aws-single-node

1 similar comment
@omertuc
Copy link
Contributor Author

omertuc commented Mar 14, 2021

/test e2e-aws-single-node

@omertuc
Copy link
Contributor Author

omertuc commented Mar 14, 2021

/test e2e-aws-single-node

this time with m5d.4xlarge

@omertuc
Copy link
Contributor Author

omertuc commented Mar 15, 2021 •
edited
Loading

/test e2e-aws-single-node

back to 2x

@omertuc
Copy link
Contributor Author

omertuc commented Mar 15, 2021

/test e2e-aws-single-node

@omertuc
Copy link
Contributor Author

omertuc commented Mar 16, 2021

/test e2e-aws-single-node

@omertuc omertuc force-pushed the single-alerts branch 2 times, most recently from 5e45753 to 5b1b6d4 Compare March 31, 2021 08:44
@omertuc omertuc changed the title Allow KubeMemoryOvercommit and KubeCPUOvercommit alerts in single replica topology Allow several alerts in single replica topology Mar 31, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-aws-single-node

@omertuc
Allow several alerts in single replica topology
e362a7a 
See TODO comments added in this commit for more information
@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-aws-single-node

2 similar comments
@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-aws-single-node

@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-aws-single-node

@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-agnostic-cmd
/test e2e-metal-ipi-ovn-ipv6
/test e2e-aws-fips
/test e2e-aws-serial
/test e2e-aws-disruptive

@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-aws-single-node
/test e2e-agnostic-cmd
/test e2e-metal-ipi-ovn-ipv6

@omertuc
Copy link
Contributor Author

omertuc commented Mar 31, 2021

/test e2e-aws-single-node

/test e2e-agnostic-cmd

@omertuc
Copy link
Contributor Author

omertuc commented Apr 1, 2021

/test e2e-agnostic-cmd

1 similar comment
@omertuc
Copy link
Contributor Author

omertuc commented Apr 1, 2021

/test e2e-agnostic-cmd

@omertuc
Copy link
Contributor Author

omertuc commented Apr 28, 2021

These alerts have been fixed by now, PR no longer relevant

@omertuc omertuc closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

@squat squat Awaiting requested review from squat

1 more reviewer

@smarterclayton smarterclayton smarterclayton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@romfreiman romfreiman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omertuc @romfreiman @openshift-ci-robot @smarterclayton