Skip to content

[release-4.5] Bug 1907507: Fix skipping of SDN tests #25768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 21, 2020
Merged

[release-4.5] Bug 1907507: Fix skipping of SDN tests #25768

openshift-merge-robot merged 1 commit into from
Dec 21, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 15, 2020

This is an automated cherry-pick of #25670

/assign squeed

@danwinship
Fix openshift-sdn mode detection in e2e tests
0d204db 
Our attempt to determine the plugin mode was generating

pluginName="Flag --config has been deprecated, use --kubeconfig instead\nredhat/openshift-ovs-networkpolicy"
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2020

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1890297 with correct target release. Retitling PR to link to clone:
/retitle [release-4.5] Bug 1907507: [release-4.6] Fix skipping of SDN tests

Details

In response to this:

[release-4.5] Bug 1890297: [release-4.6] Fix skipping of SDN tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1890297: [release-4.6] Fix skipping of SDN tests [release-4.5] Bug 1907507: [release-4.6] Fix skipping of SDN tests Dec 15, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 15, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1907507, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.5] Bug 1907507: [release-4.6] Fix skipping of SDN tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor

squeed commented Dec 15, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 15, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2020

@squeed: This pull request references Bugzilla bug 1907507, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1890297 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1890297 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@squeed
Copy link
Contributor

squeed commented Dec 15, 2020

/retitle [release-4.5] Bug 1907507: Fix skipping of SDN tests

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1907507: [release-4.6] Fix skipping of SDN tests [release-4.5] Bug 1907507: Fix skipping of SDN tests Dec 15, 2020
@squeed squeed mentioned this pull request Dec 15, 2020
Merged
@danwinship
Copy link
Contributor

danwinship commented Dec 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@markmc
Copy link
Contributor

markmc commented Dec 21, 2020

(patch manager) fixes running of openshift-sdn specific tests, already on 4.6 and master

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 21, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ba4f781 into openshift:release-4.5 Dec 21, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 21, 2020

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1907507 has not been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1907507: Fix skipping of SDN tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@danwinship danwinship

@squeed squeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @squeed @danwinship @openshift-bot @markmc @openshift-merge-robot