Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Dec 15, 2020

This PR vendors an unmerged branch (openshift/kubernetes#488) that corrects the vendoring of shared libraries.

Testing to see if ci will be more cooperative.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marun
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Dec 15, 2020
@marun
Copy link
Contributor Author

marun commented Dec 15, 2020

/uncc @bparees @dcbw
/cc @sttts @mfojtik @tnozicka @soltysh

@openshift-ci-robot openshift-ci-robot requested review from mfojtik, soltysh, sttts and tnozicka and removed request for bparees and dcbw December 15, 2020 06:05
@openshift-merge-robot
Copy link
Contributor

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-csi fac37ca link /test e2e-gcp-csi
ci/prow/e2e-aws-image-registry fac37ca link /test e2e-aws-image-registry
ci/prow/e2e-aws-csi fac37ca link /test e2e-aws-csi
ci/prow/e2e-gcp-upgrade fac37ca link /test e2e-gcp-upgrade
ci/prow/e2e-gcp fac37ca link /test e2e-gcp
ci/prow/e2e-aws-fips fac37ca link /test e2e-aws-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor

soltysh commented Dec 15, 2020

Closing in favor of #25764
/close

@openshift-ci-robot
Copy link

@soltysh: Closed this PR.

Details

In response to this:

Closing in favor of #25764
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants