Skip to content

Conversation

@tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Dec 14, 2020

Kube 1.20.0 introduces a default configmap in every namespace so >0 won't ever be true there.

This blocks rebase PR openshift/kubernetes#471

/cc @sttts @adambkaplan

Kube 1.20.0 introduces a default confixmap in every namespace so >0
won't ever be true there.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@sttts
Copy link
Contributor

sttts commented Dec 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka tnozicka changed the title Fix build test CM count Bug 1907373: Fix build test CM count Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 14, 2020
@openshift-ci-robot
Copy link

@tnozicka: This pull request references Bugzilla bug 1907373, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1907373: Fix build test CM count

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 14, 2020
@tnozicka
Copy link
Contributor Author

/override e2e-agnostic-cmd
test-cmd isn't related and is flaky

@openshift-ci-robot
Copy link

@tnozicka: tnozicka unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

/override e2e-agnostic-cmd
test-cmd isn't related and is flaky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tnozicka
Copy link
Contributor Author

fips: [sig-storage] Volume Placement [Feature:vsphere] test back to back pod creation and deletion with different volume sources on the same worker node [Suite:openshift/conformance/parallel] [Suite:k8s]

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Dec 14, 2020

/override ci/prow/e2e-agnostic-cmd

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-agnostic-cmd

Details

In response to this:

/override ci/prow/e2e-agnostic-cmd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Contributor

mfojtik commented Dec 14, 2020

/override ci/prow/e2e-aws-fips

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-fips

Details

In response to this:

/override ci/prow/e2e-aws-fips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Contributor Author

passed: (29.4s) 2020-12-14T11:26:37 "[sig-builds][Feature:Builds] remove all builds when build configuration is removed oc delete buildconfig should start builds and delete the buildconfig [Suite:openshift/conformance/parallel]"
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25761/pull-ci-openshift-origin-master-e2e-gcp/1338426434212859904#1:build-log.txt%3A14750

@mfojtik
Copy link
Contributor

mfojtik commented Dec 14, 2020

/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp-builds
/override ci/prow/e2e-gcp-upgrade

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-serial, ci/prow/e2e-gcp, ci/prow/e2e-gcp-builds, ci/prow/e2e-gcp-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-gcp-builds
/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit 91f2f44 into openshift:master Dec 14, 2020
@openshift-ci-robot
Copy link

@tnozicka: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1907373 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1907373: Fix build test CM count

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants