Skip to content

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Nov 30, 2020

The Provisioning and Baremetal host CRs would be created only when the Platform type is Baremetal. The recent change #25708 to update 'oc explain' tests does not take that into consideration.

@sadasu
Copy link
Contributor Author

sadasu commented Nov 30, 2020

/cc @stts @soltysh

@openshift-ci-robot
Copy link

@sadasu: GitHub didn't allow me to request PR reviews from the following users: stts.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @stts @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu
Copy link
Contributor Author

sadasu commented Nov 30, 2020

I am open to making this more refined than just removing the 2 metal3.io CRs. This is blocker for progress on our PRs.

@stbenjam
Copy link
Member

stbenjam commented Dec 1, 2020

Given we're close to feature freeze and this is now blocking work, I'm inclined to just say let's merge this one and figure out when and if to add this test when the platform is baremetal.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@stbenjam
Copy link
Member

stbenjam commented Dec 1, 2020

/assign @sttts

@openshift-merge-robot
Copy link
Contributor

@sadasu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips aef8448 link /test e2e-aws-fips
ci/prow/e2e-gcp aef8448 link /test e2e-gcp
ci/prow/e2e-agnostic-cmd aef8448 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-serial aef8448 link /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade aef8448 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we're close to feature freeze and this is now blocking work, I'm inclined to just say let's merge this one and figure out when and if to add this test when the platform is baremetal.

This is not an argument for removing tests. Where this is failing? I spoke with both @sadasu and @sttts about it, I'm willing to make this conditional but from what I've checked on an AWS installation both of these resources are there and have proper oc explain data.

@soltysh
Copy link
Contributor

soltysh commented Dec 1, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu, stbenjam
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member

stbenjam commented Dec 1, 2020

It was failing on openshift/cluster-baremetal-operator#81, but it looks like @sadasu fixed it. This might not be needed.

@sadasu
Copy link
Contributor Author

sadasu commented Dec 1, 2020

It was failing on openshift/cluster-baremetal-operator#81, but it looks like @sadasu fixed it. This might not be needed.

I didn't do anything specific in my PR to fix it. It just didn't happen in the next run. So, I suspect a timing issue.

@sadasu sadasu closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants