-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Remove 'oc explain' tests for the CRs in metal3.io #25722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sadasu: GitHub didn't allow me to request PR reviews from the following users: stts. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I am open to making this more refined than just removing the 2 metal3.io CRs. This is blocker for progress on our PRs. |
|
Given we're close to feature freeze and this is now blocking work, I'm inclined to just say let's merge this one and figure out when and if to add this test when the platform is baremetal. /lgtm |
|
/assign @sttts |
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we're close to feature freeze and this is now blocking work, I'm inclined to just say let's merge this one and figure out when and if to add this test when the platform is baremetal.
This is not an argument for removing tests. Where this is failing? I spoke with both @sadasu and @sttts about it, I'm willing to make this conditional but from what I've checked on an AWS installation both of these resources are there and have proper oc explain data.
|
/hold |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sadasu, stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
It was failing on openshift/cluster-baremetal-operator#81, but it looks like @sadasu fixed it. This might not be needed. |
I didn't do anything specific in my PR to fix it. It just didn't happen in the next run. So, I suspect a timing issue. |
The Provisioning and Baremetal host CRs would be created only when the Platform type is Baremetal. The recent change #25708 to update 'oc explain' tests does not take that into consideration.