Skip to content

Bug 1847363: Fix tests on s390x: replace centos by ubi #25558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r4f4 wants to merge 4 commits into from
Closed

Bug 1847363: Fix tests on s390x: replace centos by ubi #25558

r4f4 wants to merge 4 commits into from

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Sep 26, 2020

With this change this test passes on s390x

Signed-off-by: Rafael Fonseca [email protected]

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 26, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2020
@r4f4 r4f4 changed the title Fix rsh test to use ubi instead of centos Fix tests on s390x: replace centos by ubi Sep 27, 2020
@r4f4
Copy link
Contributor Author

r4f4 commented Sep 27, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2020
@r4f4 r4f4 mentioned this pull request Sep 27, 2020
Closed
@r4f4 r4f4 changed the title Fix tests on s390x: replace centos by ubi Bug 1847363: Fix tests on s390x: replace centos by ubi Sep 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 28, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2020

@r4f4: This pull request references Bugzilla bug 1847363, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1847363: Fix tests on s390x: replace centos by ubi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 28, 2020
@r4f4
Copy link
Contributor Author

r4f4 commented Sep 28, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 28, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2020

@r4f4: This pull request references Bugzilla bug 1847363, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 28, 2020

/retest

1 similar comment
@r4f4
Copy link
Contributor Author

r4f4 commented Sep 28, 2020

/retest

@r4f4
Copy link
Contributor Author

r4f4 commented Sep 28, 2020

/assign @knobunc

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 7, 2020

/retest

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 7, 2020

ping @knobunc

@jaypoulz
Copy link
Contributor

jaypoulz commented Oct 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaypoulz, r4f4
To complete the pull request process, please assign knobunc after the PR has been reviewed.
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 12, 2020

/assign @smarterclayton

@r4f4
Fix rsh test to use ubi instead of centos
daed55b 
With this change this test passes on s390x

Signed-off-by: Rafael Fonseca <[email protected]>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 27, 2020

/retest

2 similar comments
@jaypoulz
Copy link
Contributor

jaypoulz commented Oct 28, 2020

/retest

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 4, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 4, 2020

@r4f4: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-builds e875b36 link /test e2e-gcp-builds
ci/prow/e2e-aws-fips e875b36 link /test e2e-aws-fips
ci/prow/e2e-gcp e875b36 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 4, 2020

This PR is obsoleted by #25721 and #24887

@r4f4 r4f4 closed this Dec 4, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2020

@r4f4: This pull request references Bugzilla bug 1847363. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1847363: Fix tests on s390x: replace centos by ubi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4 r4f4 deleted the test-rsh-ubi branch December 4, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@jaypoulz jaypoulz

@smarterclayton smarterclayton

@knobunc knobunc

Labels

bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@r4f4 @openshift-ci-robot @jaypoulz @openshift-merge-robot @smarterclayton @knobunc