Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers #25501

wgahnagl · 2020-09-14T18:56:48Z

Remove potentially unhealthy symlink only for dead containers

Signed-off-by: Ted Yu zyu@redhat.com
Signed-off-by: Skyler Clark wgahnagl@protonmail.com

backport of Bug 1823406
PR #24926

openshift-ci-robot · 2020-09-14T18:56:49Z

@wgahnagl: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

UPSTREAM: 89160: Remove potentially unhealthy symlink only for dead c…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-14T18:57:11Z

Hi @wgahnagl. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-14T19:02:17Z

@wgahnagl: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

UPSTREAM: 89160: Remove potentially unhealthy symlink only for dead c…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-14T19:02:27Z

@wgahnagl: This pull request references Bugzilla bug 1878795, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1823406 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1823406 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

Bug 1878795: [4.4] UPSTREAM: 89160

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-14T19:06:32Z

@wgahnagl: This pull request references Bugzilla bug 1878795, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1823406 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1823406 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

Bug 1878795: [4.4] UPSTREAM: 89160

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-14T19:06:48Z

@wgahnagl: This pull request references Bugzilla bug 1878795, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1823406 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1823406 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

Bug 1878795: [4.4] UPSTREAM: 89160

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-09-18T18:33:23Z

/ok-to-test

…ontainers Signed-off-by: Ted Yu <zyu@redhat.com>

haircommander · 2020-09-30T17:15:50Z

/retest

haircommander · 2020-09-30T19:38:38Z

/retest

haircommander · 2020-10-01T13:45:58Z

/retest

openshift-ci-robot · 2020-10-01T14:01:26Z

@wgahnagl: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-cmd	`02f7490`	link	`/test e2e-cmd`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nee1esh · 2020-11-04T16:17:49Z

/retest

sjenning · 2020-11-04T16:27:41Z

/lgtm
/approve

openshift-ci-robot · 2020-11-04T16:31:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-04T18:39:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-04T20:49:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sdodson · 2020-11-05T14:53:13Z

/retitle Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers

openshift-bot · 2020-11-05T16:58:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-05T18:55:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-05T23:02:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-05T23:54:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-11-06T00:35:37Z

@wgahnagl: All pull requests linked via external trackers have merged:

openshift/origin#25501

Bugzilla bug 1878795 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 14, 2020

openshift-ci-robot requested review from deads2k and smarterclayton September 14, 2020 18:57

openshift-ci-robot added the vendor-update Touching vendor dir or related files label Sep 14, 2020

wgahnagl changed the title ~~UPSTREAM: 89160: Remove potentially unhealthy symlink only for dead c…~~ Bug 1878795: [4.4] UPSTREAM: 89160 Sep 14, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 14, 2020

wgahnagl force-pushed the symlink-cherry-pick branch from 900bcc7 to 6cc65ed Compare September 14, 2020 19:05

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2020

wgahnagl force-pushed the symlink-cherry-pick branch from 6cc65ed to 395395b Compare September 28, 2020 18:47

UPSTREAM: 89160: Remove potentially unhealthy symlink only for dead c…

02f7490

…ontainers Signed-off-by: Ted Yu <zyu@redhat.com>

wgahnagl force-pushed the symlink-cherry-pick branch from 395395b to 02f7490 Compare September 28, 2020 19:02

openshift-ci-robot assigned sjenning Nov 4, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020

openshift-ci-robot changed the title ~~Bug 1878795: [4.4] UPSTREAM: 89160~~ Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers Nov 5, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020

openshift-merge-robot merged commit 99078c8 into openshift:release-4.4 Nov 6, 2020

Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers #25501

Bug 1878795: UPSTREAM: 89160 Only Remove unhealthy symlink for dead containers #25501

Uh oh!

Conversation

wgahnagl commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 14, 2020

Uh oh!

openshift-ci-robot commented Sep 14, 2020

Uh oh!

openshift-ci-robot commented Sep 14, 2020

Uh oh!

openshift-ci-robot commented Sep 14, 2020

Uh oh!

openshift-ci-robot commented Sep 14, 2020

Uh oh!

openshift-ci-robot commented Sep 14, 2020

Uh oh!

haircommander commented Sep 18, 2020

Uh oh!

haircommander commented Sep 30, 2020

Uh oh!

haircommander commented Sep 30, 2020

Uh oh!

haircommander commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

nee1esh commented Nov 4, 2020

Uh oh!

sjenning commented Nov 4, 2020

Uh oh!

openshift-ci-robot commented Nov 4, 2020

Uh oh!

openshift-bot commented Nov 4, 2020

Uh oh!

openshift-bot commented Nov 4, 2020

Uh oh!

sdodson commented Nov 5, 2020

Uh oh!

openshift-bot commented Nov 5, 2020

Uh oh!

openshift-bot commented Nov 5, 2020

Uh oh!

openshift-bot commented Nov 5, 2020

Uh oh!

openshift-bot commented Nov 5, 2020

Uh oh!

openshift-ci-robot commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wgahnagl commented Sep 14, 2020 •

edited

Loading