Skip to content

Conversation

@damemi
Copy link
Contributor

@damemi damemi commented Sep 2, 2020

This bumps library-go to include the changes from openshift/library-go#877

Because oc e2e-cmd are failing in the 1.19 GA bump (openshift/oc#547) due to an out-of-bounds error trying to parse an empty Items list: https://github.com/openshift/origin/blob/master/test/extended/cmd/cmd.go#L73-L79

I'm not sure if this should just have a length check, based on the number of failures it seems like every test was failing on this which makes me think it was a bad conversion somewhere (especially since the tag field is still set to latest)

Referred failure is here: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oc/547/pull-ci-openshift-oc-master-e2e-cmd/1301215059803901952

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damemi
To complete the pull request process, please assign mfojtik
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Sep 2, 2020
@openshift-ci-robot
Copy link

@damemi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 53beeae link /test verify
ci/prow/verify-deps 53beeae link /test verify-deps
ci/prow/images 53beeae link /test images
ci/prow/e2e-gcp 53beeae link /test e2e-gcp
ci/prow/e2e-cmd 53beeae link /test e2e-cmd
ci/prow/e2e-aws-csi 53beeae link /test e2e-aws-csi
ci/prow/e2e-aws-fips 53beeae link /test e2e-aws-fips
ci/prow/e2e-aws-serial 53beeae link /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade 53beeae link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor

soltysh commented Sep 3, 2020

Replaced with #25467
/close

@openshift-ci-robot
Copy link

@soltysh: Closed this PR.

Details

In response to this:

Replaced with #25467
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants