Skip to content

Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow #25082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 13, 2020
Merged

Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow #25082

openshift-merge-robot merged 1 commit into from
Jun 13, 2020

Conversation

@frobware
Copy link
Contributor

@frobware frobware commented Jun 9, 2020 •
edited
Loading

The builder pod is taking a long time to complete in CI. In local
testing (i.e., on a quiescent cluster) it takes between 45s-60s to
complete. In CI this is taking much longer so switching to
WaitForPodRunningSlow which has a longer timeout (currently 15m).

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1845434
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1845646

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 9, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 9, 2020

@frobware: This pull request references Bugzilla bug 1845434, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

frobware commented Jun 9, 2020

/assign @knobunc

@frobware
Copy link
Contributor Author

frobware commented Jun 9, 2020

/retest

@frobware
Copy link
Contributor Author

frobware commented Jun 9, 2020

@openshift/openshift-team-network-edge

@bparees
Copy link
Contributor

bparees commented Jun 9, 2020

@frobware will this be cherry picked to 4.5? I see the test failing in our 4.2->4.5 upgrade testing:

https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade-4.2-to-4.3-to-4.4-to-4.5-ci/91


[sig-network-edge][Conformance][Area:Networking][Feature:Router]  The HAProxy router should pass the gRPC interoperability tests  [Suite:openshift/conformance/parallel/minimal] expand_less | 2m24s
-- | --
fail [github.com/openshift/origin/test/extended/router/grpc-interop.go:165]: Unexpected error:     <*status.statusError \| 0xc000167090>: {         Code: 4,         Message: "context deadline exceeded",         Details: nil,         XXX_NoUnkeyedLiteral: {},         XXX_unrecognized: nil,         XXX_sizecache: 0,     }     rpc error: code = DeadlineExceeded desc = context deadline exceeded occurred

@bparees
Copy link
Contributor

bparees commented Jun 9, 2020

i'm going to proactively clone the BZ to 4.5 to ensure it gets discussed for backport

@frobware
Copy link
Contributor Author

frobware commented Jun 9, 2020

/test e2e-aws-fips

@frobware
Copy link
Contributor Author

frobware commented Jun 9, 2020

i'm going to proactively clone the BZ to 4.5 to ensure it gets discussed for backport

Thanks. I wanted to see this pass a couple of times before making that call. I'm pretty sure 15m should be enough.

@frobware
Copy link
Contributor Author

frobware commented Jun 9, 2020

/retest

@frobware
router/grpc-interop: switch to WaitForPodRunningSlow
8d3124b 
The builder pod is taking a long time to complete in CI. In local
testing (i.e., on a quiescent cluster) it takes between 45s-60s to
complete. In CI this is taking much longer so switching to
WaitForPodRunningSlow which has a longer timeout (currently 15m).

To help reduce flakes:

- Increase internal test timeout to 5m
- Reduce number of test iterations from 5 to 2.

We want to run more than once but 5 is probably unnecessary in CI so
now reducing to just 2 iterations.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1845434
@frobware
Copy link
Contributor Author

frobware commented Jun 10, 2020

/retest

1 similar comment
@frobware
Copy link
Contributor Author

frobware commented Jun 10, 2020

/retest

@frobware frobware changed the title Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow Bug 1845646: router/grpc-interop: switch to WaitForPodRunningSlow Jun 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2020

@frobware: This pull request references Bugzilla bug 1845434, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2020

@frobware: This pull request references Bugzilla bug 1845646, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1845646: router/grpc-interop: switch to WaitForPodRunningSlow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 10, 2020
@frobware
Copy link
Contributor Author

frobware commented Jun 10, 2020

/refresh title

@frobware
Copy link
Contributor Author

frobware commented Jun 10, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2020

@frobware: This pull request references Bugzilla bug 1845646, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware frobware changed the title Bug 1845646: router/grpc-interop: switch to WaitForPodRunningSlow Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow Jun 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2020

@frobware: This pull request references Bugzilla bug 1845434, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

frobware commented Jun 10, 2020

/retest

@frobware
Copy link
Contributor Author

frobware commented Jun 11, 2020

/test e2e-aws-fips

@knobunc
Copy link
Contributor

knobunc commented Jun 11, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@frobware
Copy link
Contributor Author

frobware commented Jun 11, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 11, 2020

@frobware: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@frobware
Copy link
Contributor Author

frobware commented Jun 11, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 295a35c into openshift:master Jun 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 13, 2020

@frobware: All pull requests linked via external trackers have merged: openshift/origin#25082. Bugzilla bug 1845434 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1845434: router/grpc-interop: switch to WaitForPodRunningSlow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 13, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 13, 2020

@frobware: new pull request created: #25104

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@frobware @openshift-ci-robot @bparees @knobunc @openshift-cherrypick-robot @openshift-bot @openshift-merge-robot