Add authentication options, add github and google oauth implementations #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For the osincli update, can you reword the commit title to match the other version bump commits (include the updated version) |
Contributor
Author
|
@smarterclayton reactions to comments complete |
Contributor
|
LGTM [merge] |
Contributor
|
Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/266/) (Image: devenv-fedora_288) |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
|
Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/303/) |
secure endpoints behind token Conflicts: pkg/cmd/server/origin/auth.go WIP - handle the google oauth callback Conflicts: pkg/cmd/server/origin/auth.go
Refactor auth mux wiring Code review Remove custom String() functions, dump config in verbose logging only Move token auth failure logging into failure handler Validate state, redirect inside success handler, add success handler chain Code review 2: godoc, require error handlers and use consistently, fix closure bug
Contributor
Author
|
re[merge] |
Contributor
|
Evaluated for origin up to 4dd2e0a |
openshift-bot
pushed a commit
that referenced
this pull request
Oct 29, 2014
Merged by openshift-bot
smarterclayton
pushed a commit
to smarterclayton/origin
that referenced
this pull request
Jun 9, 2016
Merged by openshift-bot
danwinship
pushed a commit
to danwinship/origin
that referenced
this pull request
Jun 24, 2016
Crash in the right place if the ClusterNetwork record can't be read
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
) * Add Poll method to broker clients so that we can move the polling logic to controller where it belongs away from the client. First cut just commiting so I can bring the branch up to date * add pollers and callbacks that should have all the necessary pieces for discussion * rebase and actually add the poller, fake_poller & exponential back off poller * fix compile errors * fix lint warning * fix typo, return correct types after rebase * add support for async deprovision * Generated file changes for adding AsyncOpInProgress status field * Change to use AsyncOpInProgress status field instead of Async Condition * use queues, refactor controller code that was being repeated in multiple places to a method * extract and make the getserviceclass... method specific to bindings * fix tests add coverage * add test for making sure that on async create, entry gets pushed into queue correctly * Add more tests, wire return code for poll last operation through so that we can handle 409 properly * move poll method inside reconcileinstance as per discussion * Add tests for pollinstance and bind failing during asynch op on a service instance * Add tests for polling deprovisioning with/without finalizers, small cleanups * remove last operation from the check sum, it will move to the status more than likely, and is not part of the reconciling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smarterclayton review