-
Notifications
You must be signed in to change notification settings - Fork 4.8k
WIP Enable configuration of bound service account tokens #24416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@marun: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // request-timeout | ||
| // runtime-config | ||
| // service-account-api-audiences | ||
| // service-account-issuer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this commit needs a proper UPSTREAM: <carry>: ... commit msg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm otherwise.
|
You need to add validation for the origin/vendor/k8s.io/kubernetes/pkg/kubeapiserver/options/authentication.go Lines 173 to 175 in 0292713
|
|
Since the bound token flags are already exposed by the apiserver, this PR is not necessary. |
NOTE This PR is not mergeable until openshift/api#569 merges.
Implements operand support for openshift/enhancements#150.